Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test (kubernetes-client-api) : Add test in AbstractHttpLoggingInterceptor to not consume response bytes (#5251) #5532

Merged
merged 1 commit into from
Nov 9, 2023
Merged

test (kubernetes-client-api) : Add test in AbstractHttpLoggingInterceptor to not consume response bytes (#5251) #5532

merged 1 commit into from
Nov 9, 2023

Conversation

rohanKanojia
Copy link
Member

Description

Fix #5251

Add a unit test in AbstractHttpLoggingInterceptor to verify response bytes are not consumed after they've been processed by HttpLoggingInterceptor.

I've verified that test fails when I revert #5250 in httpclient-okhttp and httpclient-vertx modules

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@rohanKanojia
test (kubernetes-client-api) : Add test in AbstractHttpLoggingInterce…
425af2a 
…ptor to not consume response bytes (fabric8io#5251)

Add a unit test in AbstractHttpLoggingInterceptor to verify response
bytes are not consumed after they've been processed by
HttpLoggingInterceptor.

I've verified that test fails when I revert fabric8io#5250
in httpclient-okhttp and httpclient-vertx modules

Signed-off-by: Rohan Kumar <[email protected]>
@rohanKanojia rohanKanojia mentioned this pull request Oct 19, 2023
Closed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@rohanKanojia rohanKanojia marked this pull request as ready for review October 20, 2023 06:56
@manusa manusa added this to the 6.10.0 milestone Nov 9, 2023
@manusa manusa merged commit fdce3ca into fabric8io:main Nov 9, 2023
20 checks passed
@rohanKanojia rohanKanojia deleted the pr/issue5251 branch November 9, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunix sunix sunix approved these changes

@manusa manusa manusa approved these changes

@oscerd oscerd Awaiting requested review from oscerd oscerd is a code owner

@shawkins shawkins Awaiting requested review from shawkins shawkins is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.10.0
Development

Successfully merging this pull request may close these issues.

Create test to ensure HttpLoggingInterceptor doesn't consume bytes
3 participants
@rohanKanojia @manusa @sunix