Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #5117: correcting the call to the actual consumer, showing bytes #5146

Merged
merged 1 commit into from
May 29, 2023
Merged

fix #5117: correcting the call to the actual consumer, showing bytes #5146

merged 1 commit into from
May 29, 2023

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented May 17, 2023 •
edited by rohanKanojia
Loading

Description

Fix #5117
Ensures the actual consumer is called, prevents decoding errors from logging the response, and showing the total bytes when truncated.

It is possible with the way we are doing decoding that multi-byte values could cross a single buffer, at which point we'll simply stop logging the response and consider it truncated. We could improve upon that if needed.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit 640721c into fabric8io:master May 29, 2023
@manusa manusa mentioned this pull request Jun 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@manusa manusa manusa approved these changes

@oscerd oscerd Awaiting requested review from oscerd

@sunix sunix Awaiting requested review from sunix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

client.pods().inNamespace("x").list(); timeouts in version 6.6.0
3 participants
@shawkins @manusa @rohanKanojia