-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClusterRole and ClusterRoleBinding should be NonNamespacedOperation in RbacAPIGroupClient #3155
Comments
I would like to try. |
@MUzairS15 : Shall I assign issue to you then? |
ready to work on this issue, Assign if possible. |
yes sure |
How do i check if i had been successfull, running which test can help? |
@MUzairS15 : Are you working on this issue? Running |
@sourabhkumar45 : I've created two more good first issues. Could you please check if you can pick any one of these instead? |
…cedOperation in RbacAPIGroupClient * Fixes #2526 Updated CHEATSHEET.md Added example for how to configure okhttp logging-interceptor. * Updated PR * Updated changes * Changed clusterRoleBindings and clusterRoles to return NonNamespace Operation instead of Mixed operation * Changed clusterRoleBindings and clusterRoles to return NonNamespace Operation instead of Mixed operation
ClusterRole and ClusterRoleBinding are Cluster scoped Kubernetes resources:
But we're right now using
MixedOperation
for these which also exposesinNamespace
method. It doesn't make sense to have this method for a Cluster Scoped resource. We should useNonNamespacedOperation
instead.RbacApiGroupDSL:
kubernetes-client/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/RbacAPIGroupDSL.java
Lines 34 to 37 in cc4945f
RbacApiGroupClient
kubernetes-client/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/RbacAPIGroupClient.java
Lines 48 to 57 in cc4945f
We need to modify
clusterRoles()
andclusterRoleBindings()
to return NonNamespaceOperation instead of MixedOperationThe text was updated successfully, but these errors were encountered: