Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#Fixes 3155 Made Changes to RbacGroupAPIGroupClient and RbacAPIGroupDSL files #3211

Merged
merged 10 commits into from
Jun 7, 2021
Merged

#Fixes 3155 Made Changes to RbacGroupAPIGroupClient and RbacAPIGroupDSL files #3211

merged 10 commits into from
Jun 7, 2021

Conversation

MUzairS15
Copy link
Contributor

@MUzairS15 MUzairS15 commented Jun 3, 2021 •
edited by rohanKanojia
Loading

Description

Fix #3155

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@centos-ci
Copy link

Can one of the admins verify this patch?

@MUzairS15 MUzairS15 changed the title #Fixes 3155 #Fixes 3155 Made Changes to RbacGroupAPIGroupClient and RbacAPIGroupDSL files Jun 3, 2021
@rohanKanojia rohanKanojia requested review from oscerd and manusa June 4, 2021 14:54
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

manusa
manusa approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit 3140498 into fabric8io:master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@manusa manusa manusa approved these changes

@oscerd oscerd Awaiting requested review from oscerd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ClusterRole and ClusterRoleBinding should be NonNamespacedOperation in RbacAPIGroupClient
4 participants
@MUzairS15 @centos-ci @manusa @rohanKanojia