Use diamond operator (<>) wherever possible

[rohanKanojia]

We're already on Java 8 and we can use this diamond operator which was introduced in Java 7. Yet, there are lots of occurrences in code where we're still not using it. For more information about this, see this Sonar rule[0]

In case anyone is interested in fixing this, you can check all the occurrences where diamond operator could be used here[1]

[0] https://sonarcloud.io/organizations/fabric8io/rules?open=java%3AS2293&rule_key=java%3AS2293
[1] https://sonarcloud.io/organizations/fabric8io/issues?projects=fabric8io_kubernetes-client&resolved=false&rules=java%3AS2293

[theexplorist]

@rohanKanojia Assign me this please!

[AvineshTripathi]

@rohanKanojia i wanna work on this issue, being a newbie can you help me in this ?

[rohanKanojia]

@AvineshTripathi : oh, unfortunately someone else picked up this issue. Shall I create another one for you?

[AvineshTripathi]

@rohanKanojia sure i would love to work but thing is I m a newbie with knowledge of java and a very little about docker and kubernetes so if you can help me get into contributions that would be really appreciated ..

[theexplorist]

@rohanKanojia is this issue resolved?
Can i work on this issue? If no, can you assign one for me.

I am working on it, you can check the assigned tag above!

[rohanKanojia]

@ps-19 : You can pick some other issue if you want #3086

[Shatakshi0805]

Can I work on this? @rohanKanojia

[rohanKanojia]

@Shatakshi0805 : I'm sorry for the late reply. I was on PTO. I have created some extra issues. Could you please check if you can pick one of these:

good first issue Easy hack; Good issue for new contributors

[Shatakshi0805]

That's not a problem. yes, I will definitely check these issues. Thanks!

[aadityasinha-dotcom]

Can I work on this issue?

[doitpratik]

it this issue has been solved ??
I can see 1 open pull request

[rohanKanojia]

@soham283 : I think all places are still not updated: https://sonarcloud.io/organizations/fabric8io/issues?projects=fabric8io_kubernetes-client&resolved=false&rules=java%3AS2293

[doitpratik]

Then İ would like to work on this issue

[aadityasinha-dotcom]

I had already made a pr for this. Can anyone review that?

[doitpratik]

assign me this task @rohanKanojia

[doitpratik]

any updates, is this issue has been solved or not?

[rohanKanojia]

There are still places where this needs to be fixed. You can see files affected here:

https://sonarcloud.io/issues?severities=MINOR
(Ctrl + F diamond) and you'll see highlighted places

[doitpratik]

can you please assign this issue to me?

[Ashyum]

can I work on this issue?

[doitpratik]

@Ashyum issue is assigned to me it will be great if you can find another issue to work on, since I am following this issue from 2-3 months approx

[mhammadsaani]

Hey @rohanKanojia, is this issues solved or work needed on this?
If not then i would love to work on this!

[rohanKanojia]

There are still some places where we need to fix this

https://github.com/fabric8io/kubernetes-client/blob/master/extensions/certmanager/model-v1/src/main/java/io/fabric8/certmanager/api/model/v1/CertificateRequestSpec.java

https://github.com/fabric8io/kubernetes-client/blob/master/extensions/certmanager/model-v1beta1/src/main/java/io/fabric8/certmanager/api/model/v1beta1/CertificateRequestSpec.java

https://github.com/fabric8io/kubernetes-client/blob/master/extensions/certmanager/model-v1/src/main/java/io/fabric8/certmanager/api/model/acme/v1/ACMEChallengeSolverHTTP01Ingress.java

https://github.com/fabric8io/kubernetes-client/blob/master/extensions/certmanager/model-v1beta1/src/main/java/io/fabric8/certmanager/api/model/acme/v1beta1/ACMEChallengeSolverHTTP01Ingress.java

https://github.com/fabric8io/kubernetes-client/blob/master/extensions/istio/model-v1alpha3/src/main/java/io/fabric8/istio/api/networking/v1alpha3/CorsPolicy.java

Would be awesome if you could fix this if you get time

[mhammadsaani]

Just to clear my mind, I have to do this,
if it is something like this:
List usages = new ArrayList()
I have to make it look like
private List usages = new ArrayList<>()

Or you can share some resource which can help me understand better

[rohanKanojia]

Yes, you're right. You can take a look into Sonar Rule description[0]

[0] https://sonarcloud.io/organizations/fabric8io/rules?open=java%3AS2293&rule_key=java%3AS2293

[mhammadsaani]

Yes, you're right. You can take a look into Sonar Rule description[0]

[0] https://sonarcloud.io/organizations/fabric8io/rules?open=java%3AS2293&rule_key=java%3AS2293

Yes, assign this to me @rohanKanojia