I fixed the usage of the diamond operator in 'additionalProperties' Map. #3341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Sorry for not being clear. You need to fix it in other places as well. Check this link to find other classes with same code smell |
| @@ -72,7 +72,6 @@ | |||
| private java.lang.String serviceType; | |||
| @JsonIgnore | |||
| private Map<java.lang.String, Object> additionalProperties = new HashMap<java.lang.String, Object>(); | |||
There was a problem hiding this comment.
Suggested change
| private Map<java.lang.String, Object> additionalProperties = new HashMap<java.lang.String, Object>(); | |
| private Map<java.lang.String, Object> additionalProperties = new HashMap<>(); |
|
@BalintViragJ: polite ping, are you still working on this? Could you please update this PR as per requested changes? |
|
A polite ping, still working on this patch? |
Hi! I am not working on the patch. Sorry for the delay in the reply. |
|
Closing this for the moment, please be aware it can anytime be reopened, should you want to continue working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the lack of diamond operator in the instantiation of additionalProperties Map
Issue number: #3163
Link for the issue:
#3163