Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing word "valid" in attestation gossip conditions #1744

Merged
merged 1 commit into from
Apr 22, 2020
Merged

add missing word "valid" in attestation gossip conditions #1744

merged 1 commit into from
Apr 22, 2020

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Apr 22, 2020

nitpick -- make sure only preventing duplicate senders if you've seen a valid attestation from that validator

protolambda
protolambda approved these changes Apr 22, 2020
View reviewed changes
Copy link
Collaborator

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JustinDrake
Copy link
Collaborator

+1 for nitpicks 😂

@djrtwo
Copy link
Contributor Author

djrtwo commented Apr 22, 2020

got me 🤣

@djrtwo djrtwo merged commit d295669 into dev Apr 22, 2020
@djrtwo djrtwo deleted the p2p-nitpick branch April 22, 2020 22:05
@terencechain terencechain mentioned this pull request Apr 27, 2020
Closed
9 tasks
@ColinSchwarz ColinSchwarz mentioned this pull request Apr 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protolambda protolambda protolambda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djrtwo @JustinDrake @protolambda