Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align to spec v0.11.2 #5655

Closed
9 tasks done
terencechain opened this issue Apr 27, 2020 · 3 comments
Closed
9 tasks done

Align to spec v0.11.2 #5655

terencechain opened this issue Apr 27, 2020 · 3 comments
Labels
Help Wanted Extra attention is needed

Comments

@terencechain
Copy link
Member

terencechain commented Apr 27, 2020

🚀 Feature Request

Description

With the release of v0.11.2, this issue tracks to the progress to align Prysm to v0.11.2 which is important for multi client test net. This release does not contain breaking changes to the existing testnet

Beacon chain

Networking

@terencechain terencechain added the Help Wanted Extra attention is needed label Apr 27, 2020
@terencechain
Copy link
Member Author

I'm gonna go against the spec and keep the is_valid_indexed_attestation indices length check. The spec assumes construction of the struct protects against invariant-length. Even if it does, it doesn't hurt to double check again on the application level

@terencechain
Copy link
Member Author

This can be closed. Can you take a look at the networking change @nisdas before we close this? I think it's all done there's no action from our end

@nisdas
Copy link
Member

nisdas commented May 6, 2020

There was actually one more change left to do, sorry I missed your comment @terencechain . I am opening a PR for it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants