Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note about distributing bootnode ENRs prior to genesis #1730

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Apr 16, 2020

As discussed with @AgeManning and @nisdas, bootnode ENRs need to be distributed prior to learning genesis_validators_root. A note of guidance for how to do this in a standard way has been added.

Note: circleci cache got messed up so bumped version

@djrtwo
Copy link
Contributor Author

djrtwo commented Apr 16, 2020

@nisdas and @AgeManning: sanity check that this looks fine (and at least very similar to what you are doing already)

@djrtwo djrtwo requested a review from protolambda April 16, 2020 20:56
@nisdas
Copy link
Contributor

nisdas commented Apr 17, 2020

This looks good to me 👍 , would make sense to handle bootnodes as a special case for this.

Copy link
Collaborator

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
In current testnets it's fine, but I wonder if this can be disabled N slots after genesis, or if bootnodes are a special case regardless.

@AgeManning
Copy link
Contributor

Yeah this looks good to me also.
For us, we would likely update the bootnode's ENR after we know the value, as then the bootnode will also be discovered and participate in discovery with other nodes on the network.

@djrtwo
Copy link
Contributor Author

djrtwo commented Apr 22, 2020

made a quick note on setting bootnode ENRs to normal values after genesis info is know. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants