Add EIP: NFT Dynamic Traits #7500

ryanio · 2023-08-18T18:13:59Z

Discussion thread: https://ethereum-magicians.org/t/erc-7496-nft-dynamic-traits/15484

eth-bot · 2023-08-18T18:14:29Z

File `EIPS/eip-7496.md`

Requires 1 more reviewers from @axic, @Pandapip1, @SamWilsn, @xinbenlv

abcoathup · 2023-08-18T22:01:47Z

EIP/ERC numbering changes to sequential from 7500 and is no longer the PR number: #6990 (comment)

This PR was opened 3 minutes after #7499 so has the appearance of number sniping but as there is a spec I am not manually renumbering.

ryanio · 2023-08-18T22:22:57Z

Ah @abcoathup thanks, wasn't aware of the change in numbering. I'm okay either way if you want to assign a manual number or stick with the PR number, just let me know!

abcoathup · 2023-08-18T22:29:12Z

I'm okay either way if you want to assign a manual number or stick with the PR number, just let me know!

The sequential numbers 7500 & 7501 that would have been assigned match the PR numbers as the PRs were minutes apart.
As the PRs had specs they won't be manually renumbered as per: #6969 (comment)

EIPS/eip-7500.md

Co-authored-by: Sam Wilson <[email protected]>

EIPS/eip-7496.md

nickjuntilla · 2023-09-09T19:37:20Z

Moved my response to the discussion.

nickjuntilla · 2023-09-10T22:06:19Z

If no bulk trait updating function is implemented then those bulk updating events don't need to be included right? Is there an example implementation anywhere?

ryanio · 2023-09-11T17:01:23Z

If no bulk trait updating function is implemented then those bulk updating events don't need to be included right? Is there an example implementation anywhere?

right bulk events are provided for gas efficiency, if not needed for the specific use case the contract doesn't need to include them but apps/webistes should be expected to be listening for them.

we are working on an implementation library and will link it here (and include in the eip assets) once ready.

- getTraitValues for querying multiple traitKeys (instead of tokenIds) - Remove metadata nesting to simplify - Make trait labels optional, add translations - Include reference implementation and tests (to be continued to be added to) - Allow event emission of traitKey `*` mean to fetch values for all valid trait keys

simplify 7496

- remove param from TraitMetadataURIUpdated to save gas when emitting on chain uris - `consumptionValidationOnSale` -> `validateOnSale` - some SHOULDs to MUSTs - re-add setTraitMetadataURI and reasoning

dynamic trait updates

Pandapip1

The files MUST be CC0-licensed.

ryanio · 2023-10-18T21:48:27Z

@Pandapip1 asset files updated to CC0, thanks!

g11tech

lgtm

SamWilsn · 2023-10-21T15:34:07Z

EIPS/eip-7496.md

+Contracts implementing this EIP MUST include the events, getters, and setters as defined below, and MUST return `true` for [ERC-165](./eip-165.md) `supportsInterface` for `0xaf332f3e`, the 4 byte `interfaceId` for this ERC.
+
+```solidity
+interface IERC7496 is IERC165 {


I have been told in the past that explicitly extending ERC165 in your interface causes problems. I'm not sure how true that is, but this is pretty common:

Suggested change

interface IERC7496 is IERC165 {

interface IERC7496 /* is IERC165 */ {

thanks, makes sense, have removed the inheritance for simplicity

SamWilsn · 2023-10-21T15:36:36Z

EIPS/eip-7496.md

+## Motivation
+
+Trait values for non-fungible tokens are often stored offchain. This makes it difficult to query and mutate these values in contract code. Specifying the ability to set and get traits onchain allows for new use cases like transacting based on a token's traits or redeeming onchain entitlements.
+


I'd like to see the motivation expanded a bit. Particularly I'd like to know why we need a general interface for traits instead of using regular getFoo() returns uint and setFoo(uint foo) style functions.

What is the motivating use case behind this proposal? What type of dapp would need to interact with different tokens and completely arbitrary traits?

thanks, added reasoning for the motivating use case and why this over get*/set* style functions

SamWilsn · 2023-10-21T15:42:21Z

EIPS/eip-7496.md

+    event TraitUpdatedRangeUniformValue(bytes32 indexed traitKey, uint256 fromTokenId, uint256 toTokenId, bytes32 traitValue);
+    event TraitUpdatedList(bytes32 indexed traitKey, uint256[] tokenIds);
+    event TraitUpdatedListUniformValue(bytes32 indexed traitKey, uint256[] tokenIds, bytes32 traitValue);
+    event TraitMetadataURIUpdated();


If the metadata changes without changing the URI, should this event be emitted?

yes, this is outlined in the Events section of the spec:

Updating the trait metadata MUST emit the event TraitMetadataURIUpdated so offchain indexers can be notified to query the contract for the latest changes via getTraitMetadataURI().

SamWilsn · 2023-10-21T15:52:42Z

EIPS/eip-7496.md

+
+## Rationale
+
+Onchain traits can be used by contracts to get and mutate traits in a variety of different scenarios. For example, a contract that wants to entitle a token to a consumable benefit (e.g. a redeemable) can robustly reflect that onchain. Marketplaces can allow bidding on these tokens based on the trait value without having to rely on offchain state and exposing users to frontrunning attacks.


This belongs in the Motivation section. The Rationale section should explain technical choices made within the proposal itself, while the Motivation section should justify the proposal as a whole.

The Rationale section could, for example, explain the reasoning behind the validateOnSale functionality (I assume it exists to invalidate off-chain offer messages?), or why valueMappings exists.

thanks, updated

SamWilsn · 2023-10-21T15:54:25Z

EIPS/eip-7496.md

+## Test Cases
+
+Authors have included Foundry tests covering functionality of the specification in the assets folder.


Suggested change

## Test Cases

Authors have included Foundry tests covering functionality of the specification in the assets folder.

I think the tests are missing, which is fine. Can always add them later!

oops, added!

SamWilsn · 2023-10-21T15:54:43Z

EIPS/eip-7496.md

+
+## Reference Implementation
+
+Authors have included reference implementations of the specification in the assets folder.


You can link to them if you like. Something like:

[assets folder](../assets/eip-7496/DynamicTraits.sol)

thanks, linked

- remove IERC165 inheritance from interface for easier dev - add to motivation section. improve rationale section - add test case file, link to assets folder directly

github-actions · 2023-10-23T19:30:52Z

The commit 9e2770a (as a parent of 0a16f23) contains errors.
Please inspect the Run Summary for details.

SamWilsn · 2023-10-26T00:00:53Z

I am closing this pull request because we are in the process of separating EIPs and ERCs into distinct repositories. Unfortunately, as far as we are aware, GitHub does not provide any tools to ease this migration, so every pull request will need to be re-opened manually.

As this is a PR to create / modify an ERC, I will kindly ask you to redirect this to the new repository at ethereum/ERCs. We have prepared a guide to help with the process.

If there is relevant history here, please link to this PR from the new pull request.

On behalf of the EIP Editors, I apologize for this inconvenience.

Add EIP: NFT Dynamic Traits

e3ba978

ryanio requested a review from eth-bot as a code owner August 18, 2023 18:13

github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc labels Aug 18, 2023

eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Aug 18, 2023

github-actions bot added the w-ci Waiting on CI to pass label Aug 18, 2023

ryanio added 4 commits August 18, 2023 11:19

set EIP number to PR number (7500)

dfa5c9f

add discussions-to link, add to requires

7a4dc5b

add eip links

cf0c53a

fixes

04ef7ad

github-actions bot removed the w-ci Waiting on CI to pass label Aug 18, 2023

abcoathup mentioned this pull request Aug 18, 2023

Add EIP: NFT Redeemables #7501

Closed

revise

3e6bcce

fedepo reviewed Aug 19, 2023

View reviewed changes

EIPS/eip-7500.md Outdated Show resolved Hide resolved

fix discussions-to link

a5e9eeb

SamWilsn requested changes Aug 19, 2023

View reviewed changes

EIPS/eip-7500.md Outdated Show resolved Hide resolved

ryanio and others added 2 commits August 21, 2023 08:36

Update EIPS/eip-7500.md

2a949da

Co-authored-by: Sam Wilson <[email protected]>

update file name

86dea79

0xanders suggested changes Aug 29, 2023

View reviewed changes

EIPS/eip-7496.md Outdated Show resolved Hide resolved

EIPS/eip-7496.md Outdated Show resolved Hide resolved

ryanio added 2 commits September 22, 2023 10:38

remove getTraitValues - no real use cases in mind to keep

34282ee

ryanio and others added 12 commits September 25, 2023 17:18

fix author username

3813658

simplify 7496

dac5ac9

round of updates

75e367d

Merge pull request #3 from montasaurus/adam/23/09/28/dynamic-traits

9836f5d

simplify 7496

updates:

ccfbc99

- remove param from TraitMetadataURIUpdated to save gas when emitting on chain uris - `consumptionValidationOnSale` -> `validateOnSale` - some SHOULDs to MUSTs - re-add setTraitMetadataURI and reasoning

add error TraitKeyNotSet

d1c050f

remove setTraitMetadataURI

cf7a6cc

updates

9e9f1de

updates re: comments on PR

b3bd44c

Merge pull request #4 from ryanio/ryan/dt-updates

fa3091e

dynamic trait updates

simplify getters/setters to accept tokenId first

d6da462

update reference implementation to latest spec

ab22c09

Pandapip1 suggested changes Oct 18, 2023

View reviewed changes

updates

4ceb226

g11tech previously approved these changes Oct 19, 2023

View reviewed changes

ryanio mentioned this pull request Oct 19, 2023

EIP Editing Office Hour Meeting 26 ethcatherders/EIPIP#277

Closed

26 tasks

add "UniformValue" events

26ea0d7

ryanio dismissed g11tech’s stale review via 26ea0d7 October 19, 2023 19:42

SamWilsn reviewed Oct 21, 2023

View reviewed changes

updates from eip editor review:

9e2770a

- remove IERC165 inheritance from interface for easier dev - add to motivation section. improve rationale section - add test case file, link to assets folder directly

github-actions bot added the w-ci Waiting on CI to pass label Oct 23, 2023

fix asset link

eebe3a2

github-actions bot removed the w-ci Waiting on CI to pass label Oct 23, 2023

SamWilsn closed this Oct 26, 2023

ryanio mentioned this pull request Nov 3, 2023

Add ERC: NFT Dynamic Traits ethereum/ERCs#26

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add EIP: NFT Dynamic Traits #7500

Add EIP: NFT Dynamic Traits #7500

ryanio commented Aug 18, 2023 •

edited

Loading

eth-bot commented Aug 18, 2023 •

edited

Loading

abcoathup commented Aug 18, 2023

ryanio commented Aug 18, 2023

abcoathup commented Aug 18, 2023

nickjuntilla commented Sep 9, 2023 •

edited

Loading

nickjuntilla commented Sep 10, 2023

ryanio commented Sep 11, 2023

Pandapip1 left a comment

ryanio commented Oct 18, 2023

g11tech left a comment

SamWilsn Oct 21, 2023

ryanio Oct 23, 2023

SamWilsn Oct 21, 2023

ryanio Oct 23, 2023

SamWilsn Oct 21, 2023

ryanio Oct 23, 2023

SamWilsn Oct 21, 2023

ryanio Oct 23, 2023

SamWilsn Oct 21, 2023

ryanio Oct 23, 2023

SamWilsn Oct 21, 2023

ryanio Oct 23, 2023

github-actions bot commented Oct 23, 2023

SamWilsn commented Oct 26, 2023

	interface IERC7496 is IERC165 {
	interface IERC7496 /* is IERC165 */ {

		## Motivation

		Trait values for non-fungible tokens are often stored offchain. This makes it difficult to query and mutate these values in contract code. Specifying the ability to set and get traits onchain allows for new use cases like transacting based on a token's traits or redeeming onchain entitlements.


		## Rationale

		Onchain traits can be used by contracts to get and mutate traits in a variety of different scenarios. For example, a contract that wants to entitle a token to a consumable benefit (e.g. a redeemable) can robustly reflect that onchain. Marketplaces can allow bidding on these tokens based on the trait value without having to rely on offchain state and exposing users to frontrunning attacks.

		## Test Cases

		Authors have included Foundry tests covering functionality of the specification in the assets folder.


		## Reference Implementation

		Authors have included reference implementations of the specification in the assets folder.

Add EIP: NFT Dynamic Traits #7500

Add EIP: NFT Dynamic Traits #7500

Conversation

ryanio commented Aug 18, 2023 • edited Loading

eth-bot commented Aug 18, 2023 • edited Loading

File EIPS/eip-7496.md

abcoathup commented Aug 18, 2023

ryanio commented Aug 18, 2023

abcoathup commented Aug 18, 2023

nickjuntilla commented Sep 9, 2023 • edited Loading

nickjuntilla commented Sep 10, 2023

ryanio commented Sep 11, 2023

Pandapip1 left a comment

Choose a reason for hiding this comment

ryanio commented Oct 18, 2023

g11tech left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Oct 23, 2023

SamWilsn commented Oct 26, 2023

ryanio commented Aug 18, 2023 •

edited

Loading

eth-bot commented Aug 18, 2023 •

edited

Loading

File `EIPS/eip-7496.md`

nickjuntilla commented Sep 9, 2023 •

edited

Loading