Add ERC: NFT Dynamic Traits #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
|
✅ All reviewers have approved. |
19 tasks
g11tech
force-pushed
the
ryan/add-eip-nft-dynamic-traits
branch
from
06f29e1 to
041d584
Compare
eip-review-bot
changed the title
…RCs into ryan/add-eip-nft-dynamic-traits
g11tech
approved these changes
Nov 3, 2023
g11tech
previously approved these changes
Nov 3, 2023
19 tasks
- use 0x000...000 instead of 0x0 - add min/maxValue for decimal - update impl to latest
eip-review-bot
previously approved these changes
Nov 28, 2023
|
test comment to trigger |
|
Might be stuck because of your assets directory. I believe it's supposed to be |
auto-merge was automatically disabled
November 28, 2023 15:47
Head branch was pushed to by a user without write access
|
The commit 1c77ed7 (as a parent of 736d57c) contains errors. |
SamWilsn
approved these changes
Nov 28, 2023
eip-review-bot
approved these changes
Nov 28, 2023
eip-review-bot
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion thread: https://ethereum-magicians.org/t/erc-7496-nft-dynamic-traits/15484
Prior PR: ethereum/EIPs#7500