Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-6909: Update reference implementation to specification #7499

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

jtriley-eth
Copy link
Contributor

This updates the reference implementation to match the recent change to return boolean values from state-modifying methods.

Additionally, it conforms to the "should" statement relating to allowance deduction on infinite approvals.

@github-actions github-actions bot added c-update Modifies an existing proposal s-draft This EIP is a Draft t-erc labels Aug 18, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Aug 18, 2023

✅ All reviewers have approved.

@eth-bot eth-bot changed the title Update reference implementation to specification Update EIP-6909: Update reference implementation to specification Aug 18, 2023
@eth-bot eth-bot enabled auto-merge (squash) August 18, 2023 18:11
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 9a8a1f5 into ethereum:master Aug 18, 2023
15 of 16 checks passed
This was referenced Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal s-draft This EIP is a Draft t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants