Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task for Holocene System Config upgrade across sepolia/{op,mode,metal,zora} #378

Merged
merged 28 commits into from
Nov 29, 2024
Merged

add task for Holocene System Config upgrade across sepolia/{op,mode,metal,zora} #378

merged 28 commits into from
Nov 29, 2024
+456 −0

Conversation

geoknee
Copy link
Contributor

@geoknee geoknee commented Nov 26, 2024 •
edited
Loading

Closes ethereum-optimism/optimism#13029

Note: I labelled this task 20 because of this prior task (not yet merged) #374

@geoknee geoknee changed the title WIP: add task(s) for Holocene System Config upgrade across sepolia/{op,base,mode,metal,zora} add task(s) for Holocene System Config upgrade across sepolia/{op,base,mode,metal,zora} Nov 26, 2024
@geoknee geoknee changed the title add task(s) for Holocene System Config upgrade across sepolia/{op,base,mode,metal,zora} add task for Holocene System Config upgrade across sepolia/{op,mode,metal,zora} Nov 26, 2024
@Ethnical
Copy link
Contributor

Ethnical commented Nov 27, 2024 •
edited
Loading

Fyi, this is the not task 19 but 20 because this one is currently an open PR here and I assume would be merged before the current one.

@geoknee
Copy link
Contributor Author

geoknee commented Nov 27, 2024

Fyi, this is the not task 19 but 20 because this one is currently an open PR here and I assume would be merged before the current one.

I'm not sure what order they will end up being merged in. But #374 was definitely created first and reserves the task number 19.

I thought I had labelled everything here as task 20 -- did I miss something?

@geoknee
Copy link
Contributor Author

geoknee commented Nov 28, 2024

@Ethnical should I add anything into CI to check this?

@geoknee geoknee marked this pull request as ready for review November 28, 2024 13:54
@geoknee geoknee requested review from a team as code owners November 28, 2024 13:54
@geoknee geoknee requested a review from mds1 November 28, 2024 13:54
@Ethnical Ethnical self-assigned this Nov 28, 2024
@Ethnical
Copy link
Contributor

Ethnical commented Nov 28, 2024 •
edited
Loading

@Ethnical should I add anything into CI to check this?

I think you should do, if you can will check after how we can do that.

Anyway Looks Great!
I have executed run the task and check the tenderly simulation:
image

The validation matches the current states changes.

@Ethnical
Add Test CI for the task `020-holocene-system-config-upgrade-multi-ch…
9feb929 
…ain` (#380)

* add 020-holocene-system-config-upgrade-multi-chain into the CI to simulate both from SC + FND

* fix ci path

* CI: add forge clean

* remove the just install

* add back the forge install

* fix the the uppercase for the `stdJson` to `StdJson`
Ethnical
Ethnical previously approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@Ethnical Ethnical left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 🔥
I have added a small discussion for explanation on the livenessguard here
Also, I have added one request to complete the sentence and then we can merge :)

@geoknee geoknee added this pull request to the merge queue Nov 29, 2024
Merged via the queue into main with commit 954f96f Nov 29, 2024
14 checks passed
@geoknee geoknee deleted the gk/sep-020-system-config-holocene branch November 29, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ethnical Ethnical Ethnical approved these changes

@mds1 mds1 Awaiting requested review from mds1 mds1 is a code owner automatically assigned from ethereum-optimism/contract-reviewers

Assignees

@Ethnical Ethnical

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Holocene: Sepolia SystemConfig upgrades
3 participants
@geoknee @Ethnical @mds1