Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sepolia-019: Holocene FP upgrade #374

Merged
merged 8 commits into from
Dec 4, 2024
Merged

sepolia-019: Holocene FP upgrade #374

merged 8 commits into from
Dec 4, 2024

Conversation

sebastianst
Copy link
Member

@sebastianst sebastianst commented Nov 22, 2024

Description

OP Sepolia Holocene FP upgrade - sets new FDG and PDG implementations.

Tests

Verifications added for the new DGs, and correct MIPS vm.

Towards ethereum-optimism/optimism#13033

@sebastianst sebastianst requested review from a team as code owners November 22, 2024 16:50
@sebastianst sebastianst requested a review from blmalone November 22, 2024 16:50
clabby
clabby previously approved these changes Nov 22, 2024
Copy link
Member

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. Ran through the simulation and checked the deployments, looks good to me.

tasks/sep/019-fp-holocene-upgrade/NestedSignFromJson.s.sol Outdated Show resolved Hide resolved
NESTED.md Show resolved Hide resolved
clabby
clabby previously approved these changes Nov 22, 2024
Copy link
Member

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approval after the suggestion was added

.circleci/config.yml Outdated Show resolved Hide resolved
@sebastianst
Copy link
Member Author

sebastianst commented Nov 25, 2024

@mds1 I've executed the task and updated the PR accordingly. I'll address the open discussions once I'm back from vacation.

Also created a ticket to track creation of an abstract DGF update validation script at #377.

@mds1
Copy link
Contributor

mds1 commented Dec 4, 2024

Hey @sebastianst @geoknee, anything blocking getting the comments here addressed to get this PR merged?

@sebastianst
Copy link
Member Author

Hey @sebastianst @geoknee, anything blocking getting the comments here addressed to get this PR merged?

@mds1 I'll work on it this week. I am going to do a major refactor to create a validation template for the FP upgrade, so we don't need to copy-paste the validations for the sepolia fp upgrade fix and mainnet fp upgrade.

@sebastianst
Copy link
Member Author

Agreed with @mds1 that remaining open discussion items will be addressed in the follow up task to fix the Sepolia FPs with the correct DelayedWETH implementation. This task here has already been executed.

Copy link
Contributor

@mds1 mds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving per #374 (comment), this was executed successfully and comments will be addressed for future playbooks. We should also add a postCheck that reads the weth address from the dispute games, call it's version() method, and ensure the result is 1.1.0 (per https://github.com/ethereum-optimism/superchain-registry/blob/564649664d4ebfddf2a8b17b6a84e1af7b774edc/validation/standard/standard-versions-mainnet.toml#L13)

@mds1 mds1 added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit 681fb00 Dec 4, 2024
13 checks passed
@mds1 mds1 deleted the seb/sep-019-fp-holocene branch December 4, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants