-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sepolia-019: Holocene FP upgrade #374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done. Ran through the simulation and checked the deployments, looks good to me.
…SignFromJson.s.sol Co-authored-by: clabby <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-approval after the suggestion was added
Co-authored-by: Matt Solomon <[email protected]>
Hey @sebastianst @geoknee, anything blocking getting the comments here addressed to get this PR merged? |
@mds1 I'll work on it this week. I am going to do a major refactor to create a validation template for the FP upgrade, so we don't need to copy-paste the validations for the sepolia fp upgrade fix and mainnet fp upgrade. |
Agreed with @mds1 that remaining open discussion items will be addressed in the follow up task to fix the Sepolia FPs with the correct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving per #374 (comment), this was executed successfully and comments will be addressed for future playbooks. We should also add a postCheck that reads the weth address from the dispute games, call it's version()
method, and ensure the result is 1.1.0
(per https://github.com/ethereum-optimism/superchain-registry/blob/564649664d4ebfddf2a8b17b6a84e1af7b774edc/validation/standard/standard-versions-mainnet.toml#L13)
Description
OP Sepolia Holocene FP upgrade - sets new FDG and PDG implementations.
Tests
Verifications added for the new DGs, and correct MIPS vm.
Towards ethereum-optimism/optimism#13033