Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base Sepolia Holocene FP Upgrade Task #376

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Base Sepolia Holocene FP Upgrade Task #376

merged 3 commits into from
Dec 11, 2024

Conversation

awilliams1-cb
Copy link
Contributor

Description

Base Sepolia Holocene FP upgrade - sets new FDG and PDG implementations.

Tests

Verifications added for the new DGs, and correct MIPS vm.

@awilliams1-cb awilliams1-cb requested review from a team as code owners November 23, 2024 01:10
@awilliams1-cb awilliams1-cb changed the title Base Holocene FP Upgrade Task Base Sepolia Holocene FP Upgrade Task Nov 23, 2024
sebastianst
sebastianst reviewed Nov 25, 2024
View reviewed changes
Copy link
Member

@sebastianst sebastianst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This task looks ready for execution on Base Sepolia to me.

See also the open comments of @mds1 on my OP Sepolia PR #374 that apply to this PR as well.

Deferring to @mds1 for approval of this PR.

Also created a ticket to track creation of an abstract DGF update validation script at #377.

tasks/sep/base-005-fp-holocene-upgrade/README.md Outdated Show resolved Hide resolved
tasks/sep/base-005-fp-holocene-upgrade/.env Show resolved Hide resolved
tasks/sep/base-005-fp-holocene-upgrade/README.md Show resolved Hide resolved
tasks/sep/base-005-fp-holocene-upgrade/SignFromJson.s.sol Show resolved Hide resolved
@sebastianst sebastianst mentioned this pull request Nov 25, 2024
Open
@awilliams1-cb awilliams1-cb requested a review from mds1 December 4, 2024 14:28
@awilliams1-cb awilliams1-cb added this pull request to the merge queue Dec 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2024
@awilliams1-cb awilliams1-cb added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 5a499c6 Dec 11, 2024
13 checks passed
@awilliams1-cb awilliams1-cb deleted the base-sep-fp-holocene-upgrade branch December 11, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastianst sebastianst sebastianst left review comments

@BrianBland BrianBland BrianBland left review comments

@anikaraghu anikaraghu anikaraghu approved these changes

@skeletor-spaceman skeletor-spaceman Awaiting requested review from skeletor-spaceman skeletor-spaceman is a code owner automatically assigned from ethereum-optimism/contract-reviewers

@mds1 mds1 Awaiting requested review from mds1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@awilliams1-cb @BrianBland @sebastianst @anikaraghu @mds1