Add ethercrab-wire and ethercrab-wire-derive crates
#141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamwaffles
force-pushed
the
custom-derive-crates
branch
5 times, most recently
from
6f5916a
to
30f9349
Compare
jamwaffles
added a commit
that referenced
this pull request
Jan 7, 2024
To replace `packed_struct`, `num-enum` and `nom. These are experimental crates that have custom derives for reading/writing from/to EtherCAT wire representations. They will hopefully become more useful to end users in the future for things like autoconfiguration from ESI files and such. This is a split of #139 as that PR is huge and unwieldy due to high doses of scope creep
To replace `packed_struct`, `num-enum` and `nom`. These are experimental crates that have custom derives for reading/writing from/to EtherCAT wire representations. They will hopefully become more useful to end users in the future for things like autoconfiguration from ESI files and such. This is a split of #139 as that PR is huge and unwieldy due to high doses of scope creep
I believe this was accidentally broken after the merge of #134. The CI should've caught the error before this moment in time. Maybe something to do with adding the `--workspace` flag to cargo test? Unsure.
jamwaffles
force-pushed
the
custom-derive-crates
branch
from
30f9349
to
d199b29
Compare
jamwaffles
added a commit
that referenced
this pull request
Jan 7, 2024
To replace `packed_struct`, `num-enum` and `nom`. These are experimental crates that have custom derives for reading/writing from/to EtherCAT wire representations. They will hopefully become more useful to end users in the future for things like autoconfiguration from ESI files and such. This is a split of #139 as that PR is huge and unwieldy due to high doses of scope creep
jamwaffles
added a commit
that referenced
this pull request
Jan 7, 2024
jamwaffles
added a commit
that referenced
this pull request
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To replace
packed_struct,num-enumandnom.These are experimental crates that have custom derives for reading/writing from/to EtherCAT wire representations. They will hopefully become more useful to end users in the future for things like autoconfiguration from ESI files and such.
This is a split of #139 as that PR is huge and unwieldy due to high doses of scope creep.
These crates will be released with a breaking minor release of
ethercrabwhen it has migrated to use these traits.