Add 1.75 MSRV, optimise and unit test EEPROM reader #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamwaffles
force-pushed
the
eeprom-mock-2
branch
from
4a9c545
to
bfdd563
Compare
jamwaffles
force-pushed
the
eeprom-mock-2
branch
from
4da07f0
to
949f197
Compare
They're flaky but kinda useful as sanity checks without having to plug in loads of different hardware :(
jamwaffles
force-pushed
the
eeprom-mock-2
branch
from
658a677
to
474b3ca
Compare
This reverts commit 0e03692.
jamwaffles
changed the title
jamwaffles
added a commit
that referenced
this pull request
Jan 7, 2024
I believe this was accidentally broken after the merge of #134. The CI should've caught the error before this moment in time. Maybe something to do with adding the `--workspace` flag to cargo test? Unsure.
jamwaffles
added a commit
that referenced
this pull request
Jan 7, 2024
I believe this was accidentally broken after the merge of #134. The CI should've caught the error before this moment in time. Maybe something to do with adding the `--workspace` flag to cargo test? Unsure.
jamwaffles
added a commit
that referenced
this pull request
Jan 7, 2024
I believe this was accidentally broken after the merge of #134. The CI should've caught the error before this moment in time. Maybe something to do with adding the `--workspace` flag to cargo test? Unsure.
jamwaffles
added a commit
that referenced
this pull request
Jan 7, 2024
I believe this was accidentally broken after the merge of #134. The CI should've caught the error before this moment in time. Maybe something to do with adding the `--workspace` flag to cargo test? Unsure.
jamwaffles
added a commit
that referenced
this pull request
Jan 7, 2024
I believe this was accidentally broken after the merge of #134. The CI should've caught the error before this moment in time. Maybe something to do with adding the `--workspace` flag to cargo test? Unsure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganises code to allow providing an EEPROM data provider that reads from a file instead of a physical device.
Useful for unit testing the EEPROM code, and decoding/debugging EEPROM images.
This branch currently requires nightly due to async fn in trait usage. This PR will probably stay as a draft until all the features it depends on are stabilised.This PR bumps EtherCrab's MSRV to 1.75 to be able to use some async-fn-in-trait stuff.This PR also optimises the EEPROM reader so skips no longer have to read and discard all the data between the current pointer and the new offset.
TODO
Upgrade everything when embedded-hal(-async) 1.0 is releasedI'm not even using e-h wth 🤦Closes #24