Use ethercrab-wire derives, remove PduRead and PduData
#142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamwaffles
force-pushed
the
use-custom-derives
branch
from
68b1640
to
f029924
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the two aforementioned traits and replaces them with
EtherCrabWireReadandEtherCrabWireReadWriterespectively.This PR allows the removal of
packed_structandnum_enum, so closes #12 🎉.(no shade on either of these crates - they're both great - I just want/need more control over data in EtherCrab)
This PR is a split of the unwieldy #139