go.mod: name packages with go.etcd.io/etcd/v3 #11823

philips · 2020-04-26T22:36:47Z

Attempt to fix #11820

make works
./scripts/genproto.sh makes no changes after running
make test passes
ensure bill-of-materials.json is OK
TEST_OPTS="PASSES='functional'" make test

codecov-io · 2020-04-26T23:56:04Z

Codecov Report

Merging #11823 into master will decrease coverage by 0.39%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11823      +/-   ##
==========================================
- Coverage   66.29%   65.89%   -0.40%     
==========================================
  Files         403      403              
  Lines       36984    36984              
==========================================
- Hits        24517    24370     -147     
- Misses      10980    11099     +119     
- Partials     1487     1515      +28

Impacted Files	Coverage Δ
auth/range_perm_cache.go	`68.57% <ø> (ø)`
auth/store.go	`52.38% <ø> (-3.66%)`	⬇️
client/client.go	`83.98% <ø> (ø)`
client/discover.go	`0.00% <ø> (ø)`
client/keys.go	`55.77% <ø> (-35.68%)`	⬇️
client/members.go	`85.48% <ø> (ø)`
clientv3/auth.go	`51.25% <ø> (ø)`
clientv3/balancer/balancer.go	`86.36% <ø> (ø)`
clientv3/client.go	`74.05% <ø> (-0.59%)`	⬇️
clientv3/clientv3util/util.go	`0.00% <ø> (ø)`
... and 184 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 262c939...c9cdefa. Read the comment docs.

philips · 2020-04-27T00:34:44Z

Update: resolved in cf9c568

This is weird, consistently getting this error after all of this:

coverage: 28.1% of statements                                                                                                      
Too many goroutines running after all test(s).                                                                                     
1 instances of:                                                                                                                    
go.etcd.io/etcd/v3/pkg/testutil.interestingGoroutines(...)                                                                         
        /home/philips/etcd/pkg/testutil/leak.go:113 +0x8f                                                                          
go.etcd.io/etcd/v3/pkg/testutil.CheckLeakedGoroutine(...)                                                                          
        /home/philips/etcd/pkg/testutil/leak.go:45 +0xe1                                                                           
go.etcd.io/etcd/v3/etcdserver/api/v2v3_test.TestMain(...)                                                                          
        /home/philips/etcd/etcdserver/api/v2v3/main_test.go:40 +0x31c                                                              
main.main()                                                                                                                        
        _testmain.go:104 +0x334

This change makes the etcd package compatible with the existing Go ecosystem for module versioning. Used this tool to update package imports: https://github.com/KSubedi/gomove

Found potential locations via ``` git grep 'go.etcd.io/etcd$' ```

add go.etcd.io/etcd/v3 to existing filters

bill-of-materials: - update to new package names test/updatebom.sh scripts: - Update to the right package names - Don't add bom tool to go.mod

gofmt tests were failing, fix.

philips · 2020-04-28T03:03:28Z

Integration is failing on a test that almost certainly latency flakey:

--- FAIL: TestBalancerUnderNetworkPartitionWatchLeader (3.24s)
2220    network_partition_test.go:266: took too long to detect leader lost

xiang90 · 2020-04-28T15:28:54Z

@philips

Have you tried to write a simple program with etcd/client dependency?

philips · 2020-04-28T15:50:22Z

What do you mean? What is it you are trying to test?

…

On Tue, Apr 28, 2020, 8:29 AM Xiang Li ***@***.***> wrote: @philips <https://github.com/philips> Have you tried to write a simple program with etcd/client dependency? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#11823 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAIGCB3QVJS456WYLNP6UDRO3Y4PANCNFSM4MRN5O7A> .

xiang90 · 2020-04-28T15:57:09Z

What do you mean? What is it you are trying to test?

Something like

import go.etcd.io/etcd/v3/clientv3

func main() {
    _, _ = clientv3.New(...)
   ...
}

Just to make sure the client dependency can be resolved correctly outside the etcd project.

xiang90 · 2020-04-28T16:00:54Z

I gave it a try. It seems working well.

philips · 2020-04-28T16:04:22Z

OK, thanks. Does it all LGTY then?

…

On Tue, Apr 28, 2020 at 9:01 AM Xiang Li ***@***.***> wrote: I gave it a try. It seems working well. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#11823 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAIGCB22XXCKBISASNDNGDRO34UPANCNFSM4MRN5O7A> .

xiang90 · 2020-04-28T16:05:17Z

LGTM

philips · 2020-04-28T16:30:54Z

cc @etcd-io/maintainers-etcd we should all take a look at this go.mod change

gyuho

awesome, thank you so much!

philips · 2020-04-28T18:11:53Z

I am going to merge this at 2pm Pacific today (Tues. 2020-04-28) if there are no objections.

…

On Tue, Apr 28, 2020 at 10:29 AM Gyuho Lee ***@***.***> wrote: ***@***.**** approved this pull request. awesome, thank you so much! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#11823 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAIGCAYGSU2KAXUOJHFSFLRO4HAPANCNFSM4MRN5O7A> .

spzala

Great!! Thanks @philips lgtm

gyuho · 2020-04-28T18:45:41Z

@philips Can we update https://github.com/etcd-io/etcd/blob/master/CHANGELOG-3.5.md in a separate PR (or just separate commit is good too)?

philips · 2020-04-28T19:56:23Z

i will add the changelog and try to fix markdown docs before merging

Use the new package path in the docs and announce it in the CHANGELOG

philips · 2020-04-28T22:03:50Z

@gyuho Take a look at the docs and CHANGELOG entry here: d88d765

with the merge of etcd-io/etcd#11823 etcd v3.5.0 will now have a properly imported versioned path this fixes our pending migration to newer repo

philips force-pushed the v3-mod-attempt2 branch from a812af4 to 206fcf4 Compare April 26, 2020 23:14

philips force-pushed the v3-mod-attempt2 branch from 206fcf4 to 925a9a7 Compare April 27, 2020 01:26

philips marked this pull request as draft April 27, 2020 03:48

philips added 7 commits April 28, 2020 00:57

go.mod: use go.etcd.io/etcd/v3 versioning

96cce20

This change makes the etcd package compatible with the existing Go ecosystem for module versioning. Used this tool to update package imports: https://github.com/KSubedi/gomove

*: fix imports missed by gomove

7a5fefe

*: use go.etcd.io/etcd/v3 where needed

2ea4d88

Found potential locations via ``` git grep 'go.etcd.io/etcd$' ```

go.sum: cleanup after all the changes

c066230

testutil: leak: fix path for go routine filter

dd21e71

add go.etcd.io/etcd/v3 to existing filters

bill-of-materials: updates for /etcd/v3 packaging

03248a9

bill-of-materials: - update to new package names test/updatebom.sh scripts: - Update to the right package names - Don't add bom tool to go.mod

*: run gofmt and make fmt make test pass

c9cdefa

gofmt tests were failing, fix.

philips force-pushed the v3-mod-attempt2 branch from 88da7b1 to c9cdefa Compare April 28, 2020 01:00

philips marked this pull request as ready for review April 28, 2020 01:02

philips changed the title ~~WIP go.etcd.io/etcd/v3 in go.mod attempt2~~ go.mod: name packages with go.etcd.io/etcd/v3 Apr 28, 2020

philips requested a review from gyuho April 28, 2020 05:40

philips mentioned this pull request Apr 28, 2020

fix go.etcd.io/etcd versioned import path #11820

Closed

4 tasks

justinsb mentioned this pull request Apr 28, 2020

go get -u sigs.k8s.io/etcdadm fails with module path error kubernetes-retired/etcdadm#156

Closed

gyuho approved these changes Apr 28, 2020

View reviewed changes

spzala reviewed Apr 28, 2020

View reviewed changes

Documentation, CHANGELOG: use new go.etcd.io/etcd/v3 pkg

d88d765

Use the new package path in the docs and announce it in the CHANGELOG

philips merged commit b28a627 into etcd-io:master Apr 28, 2020

This was referenced Apr 28, 2020

go get error for 3.4.0 #11154

Closed

can't use etcd by go mod? #11336

Closed

andrewrynhard mentioned this pull request Apr 28, 2020

module declares its path as: go.etcd.io/bbolt,but was required as: github.com/coreos/bbolt #11749

Closed

a-palchikov mentioned this pull request Jun 8, 2020

Update k8s to v0.17.6 gravitational/planet#673

Merged

harshavardhana added a commit to harshavardhana/minio that referenced this pull request Jul 7, 2020

fix: migrate to go.etcd.io import path

ba0541a

with the merge of etcd-io/etcd#11823 etcd v3.5.0 will now have a properly imported versioned path this fixes our pending migration to newer repo

harshavardhana mentioned this pull request Jul 7, 2020

fix: migrate to go.etcd.io import path minio/minio#9987

Merged

7 tasks

harshavardhana added a commit to harshavardhana/minio that referenced this pull request Jul 7, 2020

fix: migrate to go.etcd.io import path

bf8e5d4

with the merge of etcd-io/etcd#11823 etcd v3.5.0 will now have a properly imported versioned path this fixes our pending migration to newer repo

harshavardhana added a commit to harshavardhana/minio that referenced this pull request Jul 7, 2020

fix: migrate to go.etcd.io import path

4930912

with the merge of etcd-io/etcd#11823 etcd v3.5.0 will now have a properly imported versioned path this fixes our pending migration to newer repo

harshavardhana added a commit to harshavardhana/minio that referenced this pull request Jul 7, 2020

fix: migrate to go.etcd.io import path

807b6e8

with the merge of etcd-io/etcd#11823 etcd v3.5.0 will now have a properly imported versioned path this fixes our pending migration to newer repo

harshavardhana added a commit to minio/minio that referenced this pull request Jul 8, 2020

fix: migrate to go.etcd.io import path (#9987)

72e0745

with the merge of etcd-io/etcd#11823 etcd v3.5.0 will now have a properly imported versioned path this fixes our pending migration to newer repo

ymmt2005 mentioned this pull request Aug 16, 2020

etcd 3.4 cybozu-go/neco#1095

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

go.mod: name packages with go.etcd.io/etcd/v3 #11823

go.mod: name packages with go.etcd.io/etcd/v3 #11823

philips commented Apr 26, 2020 •

edited

Loading

codecov-io commented Apr 26, 2020 •

edited

Loading

philips commented Apr 27, 2020 •

edited

Loading

philips commented Apr 28, 2020

xiang90 commented Apr 28, 2020

philips commented Apr 28, 2020 via email

xiang90 commented Apr 28, 2020

xiang90 commented Apr 28, 2020

philips commented Apr 28, 2020 via email

xiang90 commented Apr 28, 2020

philips commented Apr 28, 2020

gyuho left a comment

philips commented Apr 28, 2020 via email

spzala left a comment

gyuho commented Apr 28, 2020

philips commented Apr 28, 2020

philips commented Apr 28, 2020

go.mod: name packages with go.etcd.io/etcd/v3 #11823

go.mod: name packages with go.etcd.io/etcd/v3 #11823

Conversation

philips commented Apr 26, 2020 • edited Loading

codecov-io commented Apr 26, 2020 • edited Loading

Codecov Report

philips commented Apr 27, 2020 • edited Loading

philips commented Apr 28, 2020

xiang90 commented Apr 28, 2020

philips commented Apr 28, 2020 via email

xiang90 commented Apr 28, 2020

xiang90 commented Apr 28, 2020

philips commented Apr 28, 2020 via email

xiang90 commented Apr 28, 2020

philips commented Apr 28, 2020

gyuho left a comment

Choose a reason for hiding this comment

philips commented Apr 28, 2020 via email

spzala left a comment

Choose a reason for hiding this comment

gyuho commented Apr 28, 2020

philips commented Apr 28, 2020

philips commented Apr 28, 2020

philips commented Apr 26, 2020 •

edited

Loading

codecov-io commented Apr 26, 2020 •

edited

Loading

philips commented Apr 27, 2020 •

edited

Loading