go get -u sigs.k8s.io/etcdadm fails with module path error

[scottslowe]

I wanted to pull down etcdadm for some testing, and the go get command referenced in README.md under the "Building" section fails. Here's the final few lines of the output of the command:

...
go: github.com/xiang90/probing upgrade => v0.0.0-20190116061207-43a291ad63a2
go: github.com/ghodss/yaml upgrade => v1.0.0
go: k8s.io/client-go upgrade => v11.0.0+incompatible
go get: github.com/coreos/[email protected] updating to
	github.com/coreos/[email protected]: parsing go.mod:
	module declares its path as: go.etcd.io/bbolt
	        but was required as: github.com/coreos/bbolt

This is on an Ubuntu 19.10 system with Go 1.14.1 installed.

How can I resolve this error so that I can test etcdadm?

[dlipovetsky]

Thanks for reporting @scottslowe. I think this is related to #58.

I took a quick look, but I don't think this is a quick fix.

I have no issues building master with go 1.12.14. We'll have binaries with the next release. Can you build with go 1.12.x for now?

[dlipovetsky]

/priority important-soon

[scottslowe]

@dlipovetsky Apologies for the newbie-ish question: are you saying that go get will work if I use Go 1.12.x? (I'm guessing this side-steps the module error.)

[scottslowe]

go get failed on my main system with Go 1.12.17, as well as on a fresh Ubuntu 18.04 build VM running Go 1.12.17 (both systems reported multiple errors during compilation). However, using make from within the repository seemed to work.

[dlipovetsky]

go get failed on my main system with Go 1.12.17, as well as on a fresh Ubuntu 18.04 build VM running Go 1.12.17 (both systems reported multiple errors during compilation). However, using make from within the repository seemed to work.

Thanks a lot for checking that!

I'll need to investigate the cause. But for now, I'd like to PR a doc change, to replace go get with git clone followed by make etcdadm. WDYT?

FWIW, I've come across hard-to-understand issues with go get in other projects recently.

[scottslowe]

But for now, I'd like to PR a doc change, to replace go get with git clone followed by make etcdadm. WDYT?

Seems reasonable to me. Thanks! Let me know if there is additional testing I can do that would be helpful.

[scottslowe]

@dlipovetsky Would you like me to PR the suggested doc change?

[dlipovetsky]

@scottslowe I'm sorry, I just saw your comment! I PR'd the change myself a little while ago. I'll keep this issue open to look into the go get issue.

[justinsb]

I propose once etcd-io/etcd#11823 lands, that we move our import to be go.etcd.io/etcd, which has support for go.mod and I hope will fix this issue.

AFAICT we only use the etcd client libraries, so this shouldn't cause problems.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[111andre111]

Just to mention that, etcd-io/etcd#11823 is merged now.
@justinsb

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.