-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
can't use etcd by go mod? #11336
Comments
I ran into this same build issue today, it's due to the latest release of grpc moving that package. The build error can be worked around if the grpc 1.24.0 version is used. This ticket could probably use a better name, but the corresponding issue on the grpc side is here: grpc/grpc-go#3157 The long term fix is that etcd probably shouldn't be using this package directly, the public interface is resolver.Get("dns") |
FYI, The moved packages will be added back in grpc/grpc-go#3162. Those packages will be thin wrappers of the public APIs (e.g. |
If it's necessary to get a DNS resolver builder. It's unclear why etcd is importing the DNS package, however, as this is unexpected - can anyone explain? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I think this is fixed via #11823. I am closing this under that assumption. Please correct me if I am wrong. |
Go version: 1.13
If I download etcd by go mod, it shows an error:
The package
google.golang.org/grpc/resolver/dns
has becomed "internal" and etcd has use its own the package in vendor, but if I use go module or imported etcd in my go.mod, an error was thrown and the operation failed.The text was updated successfully, but these errors were encountered: