Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raft: use testify package in unit tests #14709

Closed
pav-kv opened this issue Nov 8, 2022 · 4 comments · Fixed by #14795, #14717 or #14747
Closed

raft: use testify package in unit tests #14709

pav-kv opened this issue Nov 8, 2022 · 4 comments · Fixed by #14795, #14717 or #14747
Assignees

Comments

@pav-kv
Copy link
Contributor

pav-kv commented Nov 8, 2022

What would you like to be added?

Use github.com/stretchr/testify/require and github.com/stretchr/testify/assert packages in all unit tests.

Demo PR: #14708

Why is this needed?

This removes much boilerplate from the tests, and improves speed and quality of understanding and modifying them.

@falser101
Copy link
Contributor

/assign

@serathius
Copy link
Member

serathius commented Nov 9, 2022

@falser101 I think the issue is already worked on. #14708
Assigning pavelkalinnikov who send the PR to avoid further confusion.

@serathius
Copy link
Member

Closed by #14708

@pav-kv
Copy link
Contributor Author

pav-kv commented Nov 9, 2022

This is not done, there will be a few commits making more tests to take advantage of this package, notably raft_test.go. The first PR linked in the description was intentionally small to demo things, but I can make the next PR complete this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment