feat: raft/log_unstable_test use testify packages in tests #14795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falser101
changed the title
Codecov Report
@@ Coverage Diff @@
## main #14795 +/- ##
==========================================
- Coverage 75.79% 75.50% -0.29%
==========================================
Files 457 457
Lines 37377 37341 -36
==========================================
- Hits 28329 28196 -133
- Misses 7288 7372 +84
- Partials 1760 1773 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ptabor
previously requested changes
Nov 17, 2022
falser101
force-pushed
the
fix/log_unstable
branch
from
78808d4 to
f20922f
Compare
|
@falser101 The linearzability failure is resolved in another PR, so please rebase this PR. |
Signed-off-by: jianfei.zhang <[email protected]>
falser101
force-pushed
the
fix/log_unstable
branch
from
f20922f to
de6b579
Compare
rebased! |
|
@ptabor please help review,thanks |
|
cc @tbg |
tbg
approved these changes
Nov 21, 2022
| t.Errorf("snap = %v, want %v", u.snapshot, &s) | ||
| } | ||
| require.Equal(t, s.Metadata.Index+1, u.offset) | ||
| require.Zero(t, len(u.entries)) |
There was a problem hiding this comment.
for next time: require.Zero(t, u.entries) is better because it will print the slice if it's not empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jianfei.zhang [email protected]
Fixed #14709