Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: raft/log_test se testify packages in tests #14747

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

falser101
Copy link
Contributor

@falser101 falser101 commented Nov 14, 2022

Signed-off-by: jianfei.zhang [email protected]
fixed #14709

@falser101
Copy link
Contributor Author

@fuweid
@ahrtr
help review, thanks!

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2022

Codecov Report

Merging #14747 (4682871) into main (970ecfc) will decrease coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #14747      +/-   ##
==========================================
- Coverage   75.66%   75.47%   -0.20%     
==========================================
  Files         457      457              
  Lines       37374    37338      -36     
==========================================
- Hits        28279    28179     -100     
- Misses       7328     7386      +58     
- Partials     1767     1773       +6     
Flag Coverage Δ
all 75.47% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/etcdserver/api/rafthttp/peer_status.go 87.87% <0.00%> (-12.13%) ⬇️
etcdutl/etcdutl/printer.go 16.66% <0.00%> (-9.05%) ⬇️
server/etcdserver/api/rafthttp/peer.go 87.01% <0.00%> (-8.45%) ⬇️
server/etcdserver/api/v3rpc/util.go 74.19% <0.00%> (-6.46%) ⬇️
server/etcdserver/api/v3rpc/lease.go 77.21% <0.00%> (-5.07%) ⬇️
server/proxy/grpcproxy/watch.go 92.48% <0.00%> (-4.05%) ⬇️
client/v3/leasing/cache.go 87.77% <0.00%> (-3.89%) ⬇️
server/etcdserver/txn/util.go 75.47% <0.00%> (-3.78%) ⬇️
server/storage/mvcc/watchable_store.go 89.13% <0.00%> (-3.63%) ⬇️
server/etcdserver/cluster_util.go 70.35% <0.00%> (-3.17%) ⬇️
... and 20 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

raft/log_test.go Outdated Show resolved Hide resolved
raft/log_test.go Show resolved Hide resolved
raft/log_test.go Show resolved Hide resolved
@falser101
Copy link
Contributor Author

done!@ahrtr

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you @falser101

raft/log_test.go Outdated Show resolved Hide resolved
raft/log_test.go Outdated Show resolved Hide resolved
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the unit test failures.

@falser101 falser101 force-pushed the fix/log_test branch 3 times, most recently from a58da36 to f423506 Compare November 15, 2022 01:52
@falser101
Copy link
Contributor Author

@ahrtr @fuweid done!

@falser101
Copy link
Contributor Author

@fuweid @ahrtr done!

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green (non-binding)

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both @falser101 and @fuweid

@ahrtr ahrtr merged commit 386e08f into etcd-io:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

raft: use testify package in unit tests
4 participants