-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: raft/log_test se testify packages in tests #14747
Conversation
Codecov Report
@@ Coverage Diff @@
## main #14747 +/- ##
==========================================
- Coverage 75.66% 75.47% -0.20%
==========================================
Files 457 457
Lines 37374 37338 -36
==========================================
- Hits 28279 28179 -100
- Misses 7328 7386 +58
- Partials 1767 1773 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bb6ee1b
to
d9fbfdb
Compare
done!@ahrtr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @falser101
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the unit test failures.
a58da36
to
f423506
Compare
Signed-off-by: jianfei.zhang <[email protected]>
f423506
to
cadf9de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on green (non-binding)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks both @falser101 and @fuweid
Signed-off-by: jianfei.zhang [email protected]
fixed #14709