ISSUE-161: General Updates on Formatters and Libraries + Markdown Twig extension #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We go for a custom extension here since the official one in Twig requires us to really write a full Service but also limits us on Drupal 8. Only Twig 2.4 is supported. This adds two new dependencies.
usage:
{{ data.description|markdown_2_html }}
@alliomeria this should do it. For the sake of time i will add this with 161 in a single commit since this also adds Markdown (and so many other things) and solves #144 This forces two permissions to be OR -ed. Means either Content: Administer display or Add, edit, and delete custom display modes. Wonder if that is enough? Or should we just go for the first?
Only use "administer node display" which translates in human to Content: Administer display
DiegoPino
added
bug
This was
linked to
issues
Jul 21, 2021
DiegoPino
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Many fixes and still WIP but quite good and needed.
See #161 but also #162
This also updates
Mirador to 3.1.1
replay.web to latest + Deep Links
Markdown back and forth (with D8 compat) Twig Extension
Fixes "Display Settings" tab to respect proper Field UI permissions (not former node.update which makes no sense for our use case) and also takes in account forced Display settings (like when you choose one instead of letting this module map one based on Type)
This also fixes via JS a Mirador issue where on Chrome/Firefox Videos would not get their media updated on Item Click/change. Was not an issue Safari. @dmer please test. I want to merge this into RC3 as soon as possible even if I do not have all Formatters updated to use JMESPATHS in this pass.