Make Display Settings Tab also respect user selected View Modes during Edit/Creation

[DiegoPino]

What?

This an enhancement of the new functionality/Service that #122 brought to us.
The new service is great and adds much more clarity to users wanting to see exactly which current View Mode is active.

If the user applies a View Mode during edit, forcing a View Mode over the computed hint this code there

format_strawberryfield/format_strawberryfield.module

Lines 93 to 106 in 4b9ab8e

	function format_strawberryfield_entity_view_mode_alter(&$view_mode, Drupal\Core\Entity\EntityInterface $entity, $context) {
	if ($entity->getEntityTypeId() != 'node') {
	return;
	}
	if ($view_mode != 'full') {
	return;
	}
	$view_mode = \Drupal::service('format_strawberryfield.view_mode_resolver')->get($entity);
	// To be determined if we want to be dependat on ds module or not
	// if so we really want to act on this alter and not the general one.
	/* \Drupal::moduleHandler()->alter('ds_switch_view_mode', $view_mode, $original_view_mode, $entity); */
	}

Respects it, but the "Display Settings Tab" will keep showing the Best candidate making it a bit confusing for enduser. We probably want to check if there is an override by the user and use in that case the selected View Mode.

It would basically the same as the alter:
If not 'full' then check
"ds_switch" => array:1 [▼
"x-default" => "search_index"
]
and use that value?

I will write a tiny tentative Pull and will ask @pcambra to review it and @alliomeria to test. Open to discussions. I just noticed this yesterday

Thanks!

[DiegoPino]

Resolved