-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates s3 construction to be closer to best practice #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seabbs
changed the title
Updates s3 construction to be closer to best practic
Updates s3 construction to be closer to best practice
Nov 15, 2024
seabbs
force-pushed
the
update-s3-approaches
branch
from
November 15, 2024 13:27
c5a69d2
to
1d40a4a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
==========================================
+ Coverage 88.55% 91.20% +2.64%
==========================================
Files 11 16 +5
Lines 402 466 +64
==========================================
+ Hits 356 425 +69
+ Misses 46 41 -5 ☔ View full report in Codecov by Sentry. |
9 tasks
athowes
approved these changes
Nov 15, 2024
This was referenced Nov 15, 2024
This was referenced Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title this updates epidist_linelist, epidist_direct_model, and epidist_latent_individual to be closer to the structures used in
scoringutils
and elsewhere. Note it also standarises entry points across models and adds a new low level default method for epidist linelist that can be used directly with simulated data.It also adds a first pass at a sensible user interface for linelist data and renames both linelist and models in line with #433