Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates s3 construction to be closer to best practice #441

Merged
merged 24 commits into from
Nov 15, 2024

Conversation

seabbs
Copy link
Contributor

@seabbs seabbs commented Nov 15, 2024

As the title this updates epidist_linelist, epidist_direct_model, and epidist_latent_individual to be closer to the structures used in scoringutils and elsewhere. Note it also standarises entry points across models and adds a new low level default method for epidist linelist that can be used directly with simulated data.

It also adds a first pass at a sensible user interface for linelist data and renames both linelist and models in line with #433

@seabbs seabbs changed the title Updates s3 construction to be closer to best practic Updates s3 construction to be closer to best practice Nov 15, 2024
@seabbs seabbs force-pushed the update-s3-approaches branch from c5a69d2 to 1d40a4a Compare November 15, 2024 13:27
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 83.89831% with 19 lines in your changes missing coverage. Please review.

Project coverage is 91.20%. Comparing base (d02c7c7) to head (0ccc524).
Report is 51 commits behind head on main.

Files with missing lines Patch % Lines
R/linelist_data.R 78.37% 16 Missing ⚠️
R/utils.R 70.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #441      +/-   ##
==========================================
+ Coverage   88.55%   91.20%   +2.64%     
==========================================
  Files          11       16       +5     
  Lines         402      466      +64     
==========================================
+ Hits          356      425      +69     
+ Misses         46       41       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seabbs seabbs requested a review from athowes November 15, 2024 15:42
@seabbs seabbs enabled auto-merge (squash) November 15, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants