Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename latent_individual and direct_model for consistency #400

Closed
athowes opened this issue Oct 21, 2024 · 10 comments
Closed

Rename latent_individual and direct_model for consistency #400

athowes opened this issue Oct 21, 2024 · 10 comments
Assignees
Labels
high Required for next release

Comments

@athowes
Copy link
Collaborator

athowes commented Oct 21, 2024

Adam to fill...

@seabbs
Copy link
Contributor

seabbs commented Oct 21, 2024

At the same time as addressing this we might want to address the naming structure for custom distributions:

log_lik_latent_lognormal <- function(i, prep) {

@athowes
Copy link
Collaborator Author

athowes commented Oct 21, 2024

At the same time as addressing this we might want to address the naming structure for custom distributions:

Yes more broadly this is the naming for custom families. Which would include the name in epidist_family and then the name in log_lik, epred and pred methods.

@athowes
Copy link
Collaborator Author

athowes commented Nov 7, 2024

What about just:

  • direct_model
  • individual_model
  • cohort_model

i.e. do we need the latent_ part in latent_individual?

@athowes
Copy link
Collaborator Author

athowes commented Nov 13, 2024

  • latent_model
  • marginal_model

@athowes
Copy link
Collaborator Author

athowes commented Nov 13, 2024

@kgostic notes this needs to be documented clearly.

@athowes
Copy link
Collaborator Author

athowes commented Nov 13, 2024

  • naive_model
  • latent_model
  • marginal_model

@athowes to implement name change.

@athowes athowes self-assigned this Nov 13, 2024
@athowes athowes added the high Required for next release label Nov 13, 2024
@seabbs
Copy link
Contributor

seabbs commented Nov 13, 2024

Thinking about this a bit more I think it needs to be marginalized_model to make sense? I am not sure we would talk about something being marginal?

@athowes
Copy link
Collaborator Author

athowes commented Nov 13, 2024

@seabbs
Copy link
Contributor

seabbs commented Nov 13, 2024

ha nice okay good point. Also pymc is looking cool these days

@athowes
Copy link
Collaborator Author

athowes commented Nov 15, 2024

Closed by #441.

@athowes athowes closed this as completed Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high Required for next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants