-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #400: Rename to naive model and latent model #433
Conversation
bbff40e
to
1fe2ce6
Compare
7896e17
to
40af7d1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #433 +/- ##
==========================================
+ Coverage 88.55% 94.17% +5.61%
==========================================
Files 11 16 +5
Lines 402 429 +27
==========================================
+ Hits 356 404 +48
+ Misses 46 25 -21 ☔ View full report in Codecov by Sentry. |
Sorry about this but duplicate work is in #441 so I think we should close this |
Pull request was closed
Hi @seabbs, I'm a bit confused/upset about you closing this. We agreed about doing the work in this PR. This was already finished before #441. The work in #441 was not part of what we agreed to work on this week, and does not have an issue, or anyone else's input. I am waiting on this name change implemented by #433 to rebase other PRs that we agreed to work on this week. So this not being merged is slowing me down on doing the work we need to do to finish up the existing issues we agreed to work on. As general principle, PRs should be scoped out and modular rather than bundled in together. Work should be agreed upon and executed, rather than unilaterally decided. These are the (good) principles that you've taught me! I'd prefer that we merged this existing PR. If there is duplicate work in #441 (as I say, which was done after this was already complete), then it'll be an easy rebase. I don't understand why not merge this and then rebase #441 with it merged in the first instance? |
Sorry for the crossed wires Adam and you are right it would be better to have PRs be based on scoped out issues. |
Too much work to rebase, closing again. |
Description
This PR closes #400. As agreed it replaces:
direct_model
withnaive_model
latent_individual
withlatent_model
I used find and replace to make sure there are no instances of "individual" or "direct" left.
This also needs me to make the change from "cohort" to "marginal" over at #221 which I'll do now.
Checklist