Issue 169: Natural scale postprocessing #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athowes
commented
Jul 18, 2024
athowes
commented
Jul 18, 2024
athowes
commented
Jul 22, 2024
|
Created new issue for follow-up a function to do strata-level delay In future will have issues with more complexity about the other features we might want to support like posterior predictive, input of other data to the strata. |
…"family_samples" as placeholder for the time being
athowes
commented
Jul 25, 2024
athowes
commented
Jul 25, 2024
athowes
commented
Jul 25, 2024
seabbs
reviewed
Jul 25, 2024
|
Waiting for one test to finish running but I think we should be good to review this now @seabbs. |
seabbs
reviewed
Jul 29, 2024
seabbs
reviewed
Jul 29, 2024
seabbs
reviewed
Jul 29, 2024
seabbs
previously approved these changes
Jul 29, 2024
seabbs
added a commit
that referenced
this pull request
Jan 10, 2025
* Remove standard function just for lognormal * Basic structure for add_natural_scale_mean_sd as generic * Building this out a bit. Add family to class. Start test script * Get link functions (but they're names, how to get functions) * Finding a barrier here about using brms::predict * Use same distributional parameter names as brms * Better documentation of data object * posterior_linpred doesn't error! * Add mean and sd for gamma * Perhaps prepare_predictions is useful? * Melt them down into long * Call to document * Format into start of tests, correct some gamma issues, use the class "family_samples" as placeholder for the time being * Add plausible tests * Linting! * Add simulation test and skip fitting test on CRAN * Do this without using reshape2 (jankily) * Making the package and vignettes (awkwardly!) compatible with changes to add_natural_scale_mean_sd * Alter tests to pass * Replace add_natural_scale_mean_sd by add_mean_sd * lp not ld * Missed one function call, and document() * Test correction --------- Co-authored-by: Sam Abbott <[email protected]> Former-commit-id: 917a141ddc1a7ca8b8efe1582c533d7c21230dc7 [formerly a1ab87144e42ed6e9118a2538eb242508658b95f] Former-commit-id: e98a329a7678bfcadbfea2386a7618e83f755832
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This draft PR will close #169.
Checklist