Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class constructor for family_samples #191

Closed
athowes opened this issue Jul 26, 2024 · 4 comments
Closed

Class constructor for family_samples #191

athowes opened this issue Jul 26, 2024 · 4 comments
Labels
wontfix This will not be worked on

Comments

@athowes
Copy link
Collaborator

athowes commented Jul 26, 2024

Could have class constructor for this.

Originally posted by @athowes in #170 (comment)

I'm a little bit unsure exactly how this would slot into the package, but we could have class constructors / validators for the family_samples classes.

Of course it would be good to check that something is a valid family_samples.

It wouldn't fix the awkwardness of e.g.

secondary_dist <- data.table(mu = 1, sigma = 1)
secondary_dist <- as_lognormal_samples(secondary_dist)
add_mean_sd(secondary_dist)

seeming a bit much (lots of code).

@seabbs
Copy link
Contributor

seabbs commented Jul 26, 2024

well I think it depends on if this is likely to be the only function that operates on samples (and I think the answer is broadly no - plotting etc) and that most users won't actually use this much as they will either work with the output of epidist or some posterior predictoin functionality both of which will automatically assign this

@athowes
Copy link
Collaborator Author

athowes commented Jul 26, 2024

I think it won't be the only function, though perhaps other functions will operate on the output of e.g. add_mean_sd say.

And I agree users won't use it much.

@athowes athowes added the wontfix This will not be worked on label Aug 8, 2024
@athowes
Copy link
Collaborator Author

athowes commented Aug 8, 2024

Labelling this as wontfix as I don't know that we need it.

@seabbs
Copy link
Contributor

seabbs commented Oct 4, 2024

I think we no longer need this so closing.

@seabbs seabbs closed this as not planned Won't fix, can't repro, duplicate, stale Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants