-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality for generating individual or strata level delay distribution samples #188
Comments
|
yes I agree we should use the newdata approach. We can also provide some functionality to either help users extract unique data points from there data (the simple version of all strata) and potentially to grid expand this to all combinations (i.e observed/unobserved) but I think the first pass should just be creating a nice interface to the predictive abilities of brms that works with new data and with our custom probability family distributions. |
Originally posted by @seabbs in #170 (comment) Given that we are now moving towards being more family agnostic we probably want to refactor this |
yes agree |
Use functionality from https://paul-buerkner.github.io/brms/articles/brms_customfamilies.html#post-processing-custom-family-models as much as possible. |
The code To fit into the way
With these three things defined then all the standard Downside: have to write these functions by family class. Suggestion: write this strata prediction function still (in a way which is 100% class agnostic) and then also write these above functions for the most common families (could just start with lognormal). I'd say that these functions are more likely to be used by expert users of the package, and then the |
In #170 we added functionality to create
mean
andsd
columns todata.table
s which contain parameters from either the lognormal or gamma distributional parameters (with the possibility to implement any other required distributions).Now we want to add functionality to allow users to easily generate the delay distributions they most care about. A first example of this would be the delay distribution estimate for each individual, or strata, in the model. This object should then naturally be able to be passed into
add_natural_scale_ mean_sd
(and indeed we will likely call it within the added function). I think plotting functionality can also be built around the output.One question to answer here is whether this should be
In the current unit test:
if found a way to do the individual one. Perhaps we should provide both, but broadly I think the strata is preferred. Also, we should really be enabling people to predit whatever they want if we can. Need to think about how to do this / play with available
brms
functionality.Notes
brms::prepare_predictions(fit)
used insideposterior_linpred
?The text was updated successfully, but these errors were encountered: