Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: use ::1 if IPFamily is IPv6 on admin server #4801

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

zirain
Copy link
Member

@zirain zirain commented Nov 28, 2024

xref: #4572

@zirain zirain requested a review from a team as a code owner November 28, 2024 02:54
@zirain zirain changed the title xds: use if IPFamily is IPv6 xds: use ::1 if IPFamily is IPv6 Nov 28, 2024
@zirain zirain changed the title xds: use ::1 if IPFamily is IPv6 xds: use ::1 if IPFamily is IPv6 on admin server Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 65.69%. Comparing base (9f9de74) to head (2fd82e4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/infrastructure/common/proxy_args.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4801      +/-   ##
==========================================
+ Coverage   65.63%   65.69%   +0.05%     
==========================================
  Files         211      211              
  Lines       31989    32001      +12     
==========================================
+ Hits        20997    21022      +25     
+ Misses       9753     9743      -10     
+ Partials     1239     1236       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks ! neat solution

@arkodg arkodg requested review from a team November 28, 2024 03:17
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@zirain zirain merged commit 17e932c into envoyproxy:main Nov 28, 2024
24 checks passed
@zirain zirain deleted the admin-listener branch November 28, 2024 03:35
zhaohuabing pushed a commit to zhaohuabing/gateway that referenced this pull request Nov 30, 2024
xds: use  if IPFamily is IPv6

Signed-off-by: zirain <[email protected]>
(cherry picked from commit 17e932c)
Signed-off-by: Huabing Zhao <[email protected]>
zhaohuabing added a commit that referenced this pull request Nov 30, 2024
* xds: use IPv4Compat on ready server (#4798)

Signed-off-by: zirain <[email protected]>
(cherry picked from commit 9f9de74)
Signed-off-by: Huabing Zhao <[email protected]>

* xds: use `::1`  if IPFamily is IPv6 on admin server (#4801)

xds: use  if IPFamily is IPv6

Signed-off-by: zirain <[email protected]>
(cherry picked from commit 17e932c)
Signed-off-by: Huabing Zhao <[email protected]>

* listen on ipv4 addresses by default (#4817)

* listen on `::` if the listener IPFamily is `IPv6` or `DualStack`
* Set `ipv4_compat` to `true` if `IPFamily` is `DualStack`

Signed-off-by: Arko Dasgupta <[email protected]>
(cherry picked from commit d1a8c47)
Signed-off-by: Huabing Zhao <[email protected]>

---------

Signed-off-by: zirain <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Arko Dasgupta <[email protected]>
Co-authored-by: zirain <[email protected]>
Co-authored-by: Arko Dasgupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants