-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xds: use ::1
if IPFamily is IPv6 on admin server
#4801
Conversation
Signed-off-by: zirain <[email protected]>
::1
if IPFamily is IPv6::1
if IPFamily is IPv6 on admin server
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4801 +/- ##
==========================================
+ Coverage 65.63% 65.69% +0.05%
==========================================
Files 211 211
Lines 31989 32001 +12
==========================================
+ Hits 20997 21022 +25
+ Misses 9753 9743 -10
+ Partials 1239 1236 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks ! neat solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
xds: use if IPFamily is IPv6 Signed-off-by: zirain <[email protected]> (cherry picked from commit 17e932c) Signed-off-by: Huabing Zhao <[email protected]>
* xds: use IPv4Compat on ready server (#4798) Signed-off-by: zirain <[email protected]> (cherry picked from commit 9f9de74) Signed-off-by: Huabing Zhao <[email protected]> * xds: use `::1` if IPFamily is IPv6 on admin server (#4801) xds: use if IPFamily is IPv6 Signed-off-by: zirain <[email protected]> (cherry picked from commit 17e932c) Signed-off-by: Huabing Zhao <[email protected]> * listen on ipv4 addresses by default (#4817) * listen on `::` if the listener IPFamily is `IPv6` or `DualStack` * Set `ipv4_compat` to `true` if `IPFamily` is `DualStack` Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit d1a8c47) Signed-off-by: Huabing Zhao <[email protected]> --------- Signed-off-by: zirain <[email protected]> Signed-off-by: Huabing Zhao <[email protected]> Signed-off-by: Arko Dasgupta <[email protected]> Co-authored-by: zirain <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]>
xref: #4572