Skip to content

Commit

Permalink
listen on ipv4 addresses by default (#4817)
Browse files Browse the repository at this point in the history 
* listen on `::` if the listener IPFamily is `IPv6` or `DualStack`
* Set `ipv4_compat` to `true` if `IPFamily` is `DualStack`

Signed-off-by: Arko Dasgupta <[email protected]>
  • Loading branch information
@arkodg
arkodg authored Nov 30, 2024
1 parent 6177ec7 commit d1a8c47
Show file tree
Hide file tree
Showing 515 changed files with 1,029 additions and 853 deletions.
25 changes: 9 additions & 16 deletions internal/cmd/egctl/testdata/translate/out/default-resources.all.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,12 @@ envoyProxyForGatewayClass:
resource_api_version: V3
static_resources:
listeners:
- name: envoy-gateway-proxy-ready-::-19001
- name: envoy-gateway-proxy-ready-0.0.0.0-19001
address:
socket_address:
address: '::'
address: '0.0.0.0'
port_value: 19001
protocol: TCP
ipv4_compat: true
filter_chains:
- filters:
- name: envoy.filters.network.http_connection_manager
Expand Down Expand Up @@ -659,8 +658,7 @@ xds:
listeners:
- address:
socketAddress:
address: '::'
ipv4Compat: true
address: 0.0.0.0
portValue: 19001
filterChains:
- filters:
Expand Down Expand Up @@ -691,7 +689,7 @@ xds:
route:
cluster: prometheus_stats
statPrefix: eg-ready-http
name: envoy-gateway-proxy-ready-::-19001
name: envoy-gateway-proxy-ready-0.0.0.0-19001
- '@type': type.googleapis.com/envoy.admin.v3.EndpointsConfigDump
dynamicEndpointConfigs:
- endpointConfig:
Expand Down Expand Up @@ -893,8 +891,7 @@ xds:
path: /dev/stdout
address:
socketAddress:
address: '::'
ipv4Compat: true
address: 0.0.0.0
portValue: 10080
defaultFilterChain:
filters:
Expand Down Expand Up @@ -953,8 +950,7 @@ xds:
path: /dev/stdout
address:
socketAddress:
address: '::'
ipv4Compat: true
address: 0.0.0.0
portValue: 8080
defaultFilterChain:
filters:
Expand Down Expand Up @@ -1021,8 +1017,7 @@ xds:
path: /dev/stdout
address:
socketAddress:
address: '::'
ipv4Compat: true
address: 0.0.0.0
portValue: 1234
filterChains:
- filters:
Expand Down Expand Up @@ -1061,8 +1056,7 @@ xds:
path: /dev/stdout
address:
socketAddress:
address: '::'
ipv4Compat: true
address: 0.0.0.0
portValue: 8443
filterChains:
- filterChainMatch:
Expand Down Expand Up @@ -1108,8 +1102,7 @@ xds:
path: /dev/stdout
address:
socketAddress:
address: '::'
ipv4Compat: true
address: 0.0.0.0
portValue: 1234
protocol: UDP
listenerFilters:
Expand Down
20 changes: 7 additions & 13 deletions internal/cmd/egctl/testdata/translate/out/from-gateway-api-to-xds.all.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -234,8 +234,7 @@
{
"address": {
"socketAddress": {
"address": "::",
"ipv4Compat": true,
"address": "0.0.0.0",
"portValue": 19001
}
},
Expand Down Expand Up @@ -296,7 +295,7 @@
]
}
],
"name": "envoy-gateway-proxy-ready-::-19001"
"name": "envoy-gateway-proxy-ready-0.0.0.0-19001"
}
]
}
Expand Down Expand Up @@ -638,8 +637,7 @@
],
"address": {
"socketAddress": {
"address": "::",
"ipv4Compat": true,
"address": "0.0.0.0",
"portValue": 10080
}
},
Expand Down Expand Up @@ -730,8 +728,7 @@
],
"address": {
"socketAddress": {
"address": "::",
"ipv4Compat": true,
"address": "0.0.0.0",
"portValue": 8080
}
},
Expand Down Expand Up @@ -836,8 +833,7 @@
],
"address": {
"socketAddress": {
"address": "::",
"ipv4Compat": true,
"address": "0.0.0.0",
"portValue": 1234
}
},
Expand Down Expand Up @@ -902,8 +898,7 @@
],
"address": {
"socketAddress": {
"address": "::",
"ipv4Compat": true,
"address": "0.0.0.0",
"portValue": 8443
}
},
Expand Down Expand Up @@ -981,8 +976,7 @@
],
"address": {
"socketAddress": {
"address": "::",
"ipv4Compat": true,
"address": "0.0.0.0",
"portValue": 1234,
"protocol": "UDP"
}
Expand Down
20 changes: 7 additions & 13 deletions internal/cmd/egctl/testdata/translate/out/from-gateway-api-to-xds.all.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,7 @@ xds:
listeners:
- address:
socketAddress:
address: '::'
ipv4Compat: true
address: 0.0.0.0
portValue: 19001
filterChains:
- filters:
Expand Down Expand Up @@ -169,7 +168,7 @@ xds:
route:
cluster: prometheus_stats
statPrefix: eg-ready-http
name: envoy-gateway-proxy-ready-::-19001
name: envoy-gateway-proxy-ready-0.0.0.0-19001
- '@type': type.googleapis.com/envoy.admin.v3.EndpointsConfigDump
dynamicEndpointConfigs:
- endpointConfig:
Expand Down Expand Up @@ -371,8 +370,7 @@ xds:
path: /dev/stdout
address:
socketAddress:
address: '::'
ipv4Compat: true
address: 0.0.0.0
portValue: 10080
defaultFilterChain:
filters:
Expand Down Expand Up @@ -431,8 +429,7 @@ xds:
path: /dev/stdout
address:
socketAddress:
address: '::'
ipv4Compat: true
address: 0.0.0.0
portValue: 8080
defaultFilterChain:
filters:
Expand Down Expand Up @@ -499,8 +496,7 @@ xds:
path: /dev/stdout
address:
socketAddress:
address: '::'
ipv4Compat: true
address: 0.0.0.0
portValue: 1234
filterChains:
- filters:
Expand Down Expand Up @@ -539,8 +535,7 @@ xds:
path: /dev/stdout
address:
socketAddress:
address: '::'
ipv4Compat: true
address: 0.0.0.0
portValue: 8443
filterChains:
- filterChainMatch:
Expand Down Expand Up @@ -586,8 +581,7 @@ xds:
path: /dev/stdout
address:
socketAddress:
address: '::'
ipv4Compat: true
address: 0.0.0.0
portValue: 1234
protocol: UDP
listenerFilters:
Expand Down
5 changes: 2 additions & 3 deletions internal/cmd/egctl/testdata/translate/out/from-gateway-api-to-xds.bootstrap.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,7 @@ xds:
listeners:
- address:
socketAddress:
address: '::'
ipv4Compat: true
address: 0.0.0.0
portValue: 19001
filterChains:
- filters:
Expand Down Expand Up @@ -168,4 +167,4 @@ xds:
route:
cluster: prometheus_stats
statPrefix: eg-ready-http
name: envoy-gateway-proxy-ready-::-19001
name: envoy-gateway-proxy-ready-0.0.0.0-19001
15 changes: 5 additions & 10 deletions internal/cmd/egctl/testdata/translate/out/from-gateway-api-to-xds.listener.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ xds:
path: /dev/stdout
address:
socketAddress:
address: '::'
ipv4Compat: true
address: 0.0.0.0
portValue: 10080
defaultFilterChain:
filters:
Expand Down Expand Up @@ -80,8 +79,7 @@ xds:
path: /dev/stdout
address:
socketAddress:
address: '::'
ipv4Compat: true
address: 0.0.0.0
portValue: 8080
defaultFilterChain:
filters:
Expand Down Expand Up @@ -148,8 +146,7 @@ xds:
path: /dev/stdout
address:
socketAddress:
address: '::'
ipv4Compat: true
address: 0.0.0.0
portValue: 1234
filterChains:
- filters:
Expand Down Expand Up @@ -188,8 +185,7 @@ xds:
path: /dev/stdout
address:
socketAddress:
address: '::'
ipv4Compat: true
address: 0.0.0.0
portValue: 8443
filterChains:
- filterChainMatch:
Expand Down Expand Up @@ -235,8 +231,7 @@ xds:
path: /dev/stdout
address:
socketAddress:
address: '::'
ipv4Compat: true
address: 0.0.0.0
portValue: 1234
protocol: UDP
listenerFilters:
Expand Down
8 changes: 3 additions & 5 deletions internal/cmd/egctl/testdata/translate/out/jwt-single-route-single-match-to-xds.all.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -234,8 +234,7 @@
{
"address": {
"socketAddress": {
"address": "::",
"ipv4Compat": true,
"address": "0.0.0.0",
"portValue": 19001
}
},
Expand Down Expand Up @@ -296,7 +295,7 @@
]
}
],
"name": "envoy-gateway-proxy-ready-::-19001"
"name": "envoy-gateway-proxy-ready-0.0.0.0-19001"
}
]
}
Expand Down Expand Up @@ -461,8 +460,7 @@
],
"address": {
"socketAddress": {
"address": "::",
"ipv4Compat": true,
"address": "0.0.0.0",
"portValue": 10080
}
},
Expand Down
8 changes: 3 additions & 5 deletions internal/cmd/egctl/testdata/translate/out/jwt-single-route-single-match-to-xds.all.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,7 @@ xds:
listeners:
- address:
socketAddress:
address: '::'
ipv4Compat: true
address: 0.0.0.0
portValue: 19001
filterChains:
- filters:
Expand Down Expand Up @@ -169,7 +168,7 @@ xds:
route:
cluster: prometheus_stats
statPrefix: eg-ready-http
name: envoy-gateway-proxy-ready-::-19001
name: envoy-gateway-proxy-ready-0.0.0.0-19001
- '@type': type.googleapis.com/envoy.admin.v3.EndpointsConfigDump
dynamicEndpointConfigs:
- endpointConfig:
Expand Down Expand Up @@ -266,8 +265,7 @@ xds:
path: /dev/stdout
address:
socketAddress:
address: '::'
ipv4Compat: true
address: 0.0.0.0
portValue: 10080
defaultFilterChain:
filters:
Expand Down
5 changes: 2 additions & 3 deletions ...rnal/cmd/egctl/testdata/translate/out/jwt-single-route-single-match-to-xds.bootstrap.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,7 @@ xds:
listeners:
- address:
socketAddress:
address: '::'
ipv4Compat: true
address: 0.0.0.0
portValue: 19001
filterChains:
- filters:
Expand Down Expand Up @@ -168,4 +167,4 @@ xds:
route:
cluster: prometheus_stats
statPrefix: eg-ready-http
name: envoy-gateway-proxy-ready-::-19001
name: envoy-gateway-proxy-ready-0.0.0.0-19001
3 changes: 1 addition & 2 deletions internal/cmd/egctl/testdata/translate/out/jwt-single-route-single-match-to-xds.listener.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ xds:
path: /dev/stdout
address:
socketAddress:
address: '::'
ipv4Compat: true
address: 0.0.0.0
portValue: 10080
defaultFilterChain:
filters:
Expand Down
Loading

0 comments on commit d1a8c47

Please sign in to comment.