Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.2] Cherry pick IPv6 support to v1.2.3 #4819

Merged
merged 3 commits into from
Nov 30, 2024
Merged

[release/v1.2] Cherry pick IPv6 support to v1.2.3 #4819

merged 3 commits into from
Nov 30, 2024

Conversation

zhaohuabing
Copy link
Member

No description provided.

zirain and others added 3 commits November 30, 2024 04:24
@zirain @zhaohuabing
xds: use IPv4Compat on ready server (envoyproxy#4798)
a6e0eef 
Signed-off-by: zirain <[email protected]>
(cherry picked from commit 9f9de74)
Signed-off-by: Huabing Zhao <[email protected]>
@zirain @zhaohuabing
xds: use ::1 if IPFamily is IPv6 on admin server (envoyproxy#4801)
4d131be 
xds: use  if IPFamily is IPv6

Signed-off-by: zirain <[email protected]>
(cherry picked from commit 17e932c)
Signed-off-by: Huabing Zhao <[email protected]>
@arkodg @zhaohuabing
listen on ipv4 addresses by default (envoyproxy#4817)
e62977b 
* listen on `::` if the listener IPFamily is `IPv6` or `DualStack`
* Set `ipv4_compat` to `true` if `IPFamily` is `DualStack`

Signed-off-by: Arko Dasgupta <[email protected]>
(cherry picked from commit d1a8c47)
Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing zhaohuabing requested a review from a team as a code owner November 30, 2024 04:33
@zhaohuabing zhaohuabing requested review from arkodg and zirain November 30, 2024 04:33
@codecov Codecov
Copy link

codecov bot commented Nov 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 65.61%. Comparing base (2493f6a) to head (e62977b).
Report is 1 commits behind head on release/v1.2.

Files with missing lines Patch % Lines
internal/gatewayapi/listener.go 40.00% 2 Missing and 1 partial ⚠️
internal/gatewayapi/helpers.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##           release/v1.2    #4819   +/-   ##
=============================================
  Coverage         65.60%   65.61%           
=============================================
  Files               211      211           
  Lines             31955    31984   +29     
=============================================
+ Hits              20963    20985   +22     
- Misses             9751     9756    +5     
- Partials           1241     1243    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaohuabing zhaohuabing merged commit 276fd20 into envoyproxy:release/v1.2 Nov 30, 2024
17 of 18 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Dec 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkodg arkodg arkodg approved these changes

@zirain zirain zirain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhaohuabing @zirain @arkodg