feat: Add service annotations to helm chart #4359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jukie <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4359 +/- ##
==========================================
- Coverage 65.98% 65.98% -0.01%
==========================================
Files 197 197
Lines 23972 23972
==========================================
- Hits 15818 15817 -1
- Misses 7027 7028 +1
Partials 1127 1127 ☔ View full report in Codecov by Sentry. |
Signed-off-by: jukie <[email protected]>
jukie
force-pushed
the
helm-service-annotations-support
branch
from
fcfbced to
9fa325f
Compare
Signed-off-by: jukie <[email protected]>
|
/retest |
1 similar comment
|
/retest |
zirain
reviewed
Sep 29, 2024
Signed-off-by: jukie <[email protected]>
|
/retest |
zirain
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Adds support for configuring annotations on the service. This is useful for things like enabling metrics scraping or other systems that monitor workload annotations.
Which issue(s) this PR fixes:
Fixes #4358