Skip to content

Commit

Permalink
feat: Add service annotations to helm chart (#4359)
Browse files Browse the repository at this point in the history
* Add service annotations to helm chart

Signed-off-by: jukie <[email protected]>

* fix

Signed-off-by: jukie <[email protected]>

* actually fix

Signed-off-by: jukie <[email protected]>

* newline

Signed-off-by: jukie <[email protected]>

---------

Signed-off-by: jukie <[email protected]>
  • Loading branch information
jukie authored Sep 29, 2024
1 parent 6edf452 commit 3b9ab70
Show file tree
Hide file tree
Showing 7 changed files with 590 additions and 0 deletions.
1 change: 1 addition & 0 deletions charts/gateway-helm/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,4 +101,5 @@ To uninstall the chart:
| global.images.ratelimit.pullSecrets | list | `[]` | |
| kubernetesClusterDomain | string | `"cluster.local"` | |
| podDisruptionBudget.minAvailable | int | `0` | |
| service.annotations | object | `{}` | |

4 changes: 4 additions & 0 deletions charts/gateway-helm/templates/envoy-gateway-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ kind: Service
metadata:
name: envoy-gateway
namespace: '{{ .Release.Namespace }}'
{{- with .Values.service.annotations }}
annotations:
{{- toYaml . | nindent 4 }}
{{- end }}
labels:
control-plane: envoy-gateway
{{- include "eg.labels" . | nindent 4 }}
Expand Down
3 changes: 3 additions & 0 deletions charts/gateway-helm/values.tmpl.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ deployment:
tolerations: []
nodeSelector: {}

service:
annotations: {}

config:
envoyGateway:
gateway:
Expand Down
1 change: 1 addition & 0 deletions site/content/en/latest/install/gateway-helm-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,5 @@ The Helm chart for Envoy Gateway
| global.images.ratelimit.pullSecrets | list | `[]` | |
| kubernetesClusterDomain | string | `"cluster.local"` | |
| podDisruptionBudget.minAvailable | int | `0` | |
| service.annotations | object | `{}` | |

1 change: 1 addition & 0 deletions site/content/zh/latest/install/gateway-helm-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,5 @@ The Helm chart for Envoy Gateway
| global.images.ratelimit.pullSecrets | list | `[]` | |
| kubernetesClusterDomain | string | `"cluster.local"` | |
| podDisruptionBudget.minAvailable | int | `0` | |
| service.annotations | object | `{}` | |

8 changes: 8 additions & 0 deletions test/helm/gateway-helm/service-annotations.in.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
global:
images:
envoyGateway:
image: "docker.io/envoyproxy/gateway-dev:latest"
pullPolicy: Always
service:
annotations:
this: that
Loading

0 comments on commit 3b9ab70

Please sign in to comment.