API: add more oidc configuration settings #3423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: huabing zhao <[email protected]>
zhaohuabing
commented
May 17, 2024
Signed-off-by: huabing zhao <[email protected]>
Signed-off-by: huabing zhao <[email protected]>
zhaohuabing
added
release-note
coro
approved these changes
May 21, 2024
There was a problem hiding this comment.
LGTM. Thanks for making this enhancement, this will be a massive improvement for us.
Another element of the OIDC flow that would be useful to configure is contained in this PR, to allow the onward JWT auth: #3274
Sam (that PR's author) is going to update that PR with the review feedback mentioned there to move it forward.
arkodg
reviewed
May 21, 2024
Signed-off-by: huabing zhao <[email protected]>
Signed-off-by: huabing zhao <[email protected]>
Signed-off-by: huabing zhao <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3423 +/- ##
=======================================
Coverage 67.39% 67.39%
=======================================
Files 166 166
Lines 20054 20054
=======================================
Hits 13515 13515
Misses 5558 5558
Partials 981 981 ☔ View full report in Codecov by Sentry. |
This was referenced May 24, 2024
Signed-off-by: huabing zhao <[email protected]>
Signed-off-by: huabing zhao <[email protected]>
zetaab
approved these changes
May 26, 2024
arkodg
reviewed
May 29, 2024
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
arkodg
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This RP adds more configuration settings to the OIDC API.
Related issue: #3405 #3395 #3462
@coro @denniskniep