Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oidc): implement additional OIDC configuration settings #3514

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

zetaab
Copy link
Contributor

@zetaab zetaab commented Jun 1, 2024

What this PR does / why we need it:

implements methods added in #3423

Which issue(s) this PR fixes:

Fixes #3405
Fixes #3395
Fixes #3462

cc @zhaohuabing

Notable thing is that this will change forwardAccessToken default behaviour from true to false.

Note:
For the release manager: the default behavior of ForwardAccessToken changed from true to false.

@zetaab zetaab requested a review from a team as a code owner June 1, 2024 09:45
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.38%. Comparing base (eaa685d) to head (83918d1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3514      +/-   ##
==========================================
+ Coverage   67.30%   67.38%   +0.07%     
==========================================
  Files         167      167              
  Lines       20308    20325      +17     
==========================================
+ Hits        13669    13695      +26     
+ Misses       5645     5638       -7     
+ Partials      994      992       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zetaab zetaab force-pushed the implementoidcstuff branch from dd10ef0 to f4beb21 Compare June 1, 2024 09:59
@zetaab zetaab force-pushed the implementoidcstuff branch from f4beb21 to 83918d1 Compare June 1, 2024 10:07
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for picking this up!

@zhaohuabing zhaohuabing added the release-note Indicates a required release note label Jun 3, 2024
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@arkodg arkodg merged commit 6e946db into envoyproxy:main Jun 3, 2024
26 checks passed
@zetaab zetaab deleted the implementoidcstuff branch June 3, 2024 19:12
@denniskniep
Copy link
Contributor

denniskniep commented Jun 21, 2024

Further Note for the release manager:
Impact is also that by default (because ForwardAccessToken is now by default false) the idToken, bearerToken and refreshToken Cookie is no longer issued. see #3638 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Indicates a required release note
Projects
None yet
4 participants