Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merge race between #3418 and #3444,#3423 #3513

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Jun 1, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: shawnh2 <[email protected]>
@shawnh2 shawnh2 requested a review from a team as a code owner June 1, 2024 03:09
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.28%. Comparing base (5619e74) to head (782e43c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3513      +/-   ##
==========================================
- Coverage   67.32%   67.28%   -0.04%     
==========================================
  Files         167      167              
  Lines       20308    20308              
==========================================
- Hits        13672    13665       -7     
- Misses       5643     5648       +5     
- Partials      993      995       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Shawn !

@arkodg arkodg merged commit eaa685d into envoyproxy:main Jun 1, 2024
26 checks passed
@shawnh2 shawnh2 deleted the fix-merge-race branch June 1, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants