add more crd (mostly CEL) validation #2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alice-Lilith
commented
Oct 27, 2023
Alice-Lilith
force-pushed
the
alicewasko/ctp-cel
branch
from
d096ee6 to
d927446
Compare
Alice-Lilith
commented
Oct 27, 2023
Codecov Report
@@ Coverage Diff @@
## main #2087 +/- ##
==========================================
- Coverage 64.37% 64.30% -0.07%
==========================================
Files 107 107
Lines 14626 14626
==========================================
- Hits 9415 9405 -10
- Misses 4649 4657 +8
- Partials 562 564 +2 |
arkodg
reviewed
Oct 27, 2023
zirain
reviewed
Oct 27, 2023
zirain
reviewed
Oct 27, 2023
added 3 commits
October 27, 2023 16:17
Signed-off-by: Alice Wasko <[email protected]>
Signed-off-by: Alice Wasko <[email protected]>
Signed-off-by: Alice Wasko <[email protected]>
Alice-Lilith
force-pushed
the
alicewasko/ctp-cel
branch
from
2709a74 to
b7bee63
Compare
arkodg
approved these changes
Oct 27, 2023
Signed-off-by: Arko Dasgupta <[email protected]>
zirain
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds some more validation to the new Policy CRDs.
Resolves: