Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CEL Validations for ClientTrafficPolicy #1965

Closed
arkodg opened this issue Oct 14, 2023 · 0 comments
Closed

Add CEL Validations for ClientTrafficPolicy #1965

arkodg opened this issue Oct 14, 2023 · 0 comments
Assignees
@Alice-Lilith
Labels
area/api API-related issues area/policy help wanted Extra attention is needed kind/enhancement New feature or request
Milestone
0.6.0

Comments

@arkodg
Copy link
Contributor

arkodg commented Oct 14, 2023

Description:

Similar to #1961, add CEL Validations in ClientTrafficPolicy API
replacing as much validation code as possible that currently lives in

gateway/internal/gatewayapi/clienttrafficpolicy.go

Line 179 in 2ecc54d

// Ensure policy can only target a Gateway

[optional Relevant Links:]

Any extra documentation required to understand the issue.
@arkodg arkodg added kind/enhancement New feature or request help wanted Extra attention is needed area/api API-related issues area/policy labels Oct 14, 2023
@arkodg arkodg added this to the 0.6.0-rc1 milestone Oct 14, 2023
@Alice-Lilith Alice-Lilith self-assigned this Oct 16, 2023
@arkodg arkodg modified the milestones: 0.6.0-rc1, 0.6.0 Oct 26, 2023
@Alice-Lilith Alice-Lilith mentioned this issue Oct 27, 2023
Merged
@arkodg arkodg closed this as completed Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alice-Lilith Alice-Lilith

Labels
area/api API-related issues area/policy help wanted Extra attention is needed kind/enhancement New feature or request
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
2 participants
@arkodg @Alice-Lilith