Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CEL validation tests for xPolicy resources #1964

Closed
arkodg opened this issue Oct 13, 2023 · 1 comment
Closed

Add CEL validation tests for xPolicy resources #1964

arkodg opened this issue Oct 13, 2023 · 1 comment
Assignees
Labels
kind/enhancement New feature or request
Milestone

Comments

@arkodg
Copy link
Contributor

arkodg commented Oct 13, 2023

Description:
We've recently started add CEL validations in our APIs e.g. #1961
Would be great to add validation tests so its easier to understand what works and what doesnt
Here's an example of how upstream does it https://github.com/kubernetes-sigs/gateway-api/blob/2b9aeb0c7fa3d558e42074486c230406e7ac80ce/pkg/test/cel/grpcroute_test.go#L416

[optional Relevant Links:]

Any extra documentation required to understand the issue.

@arkodg arkodg added the kind/enhancement New feature or request label Oct 13, 2023
@arkodg arkodg added this to the 0.6.0-rc1 milestone Oct 13, 2023
@arkodg arkodg added the help wanted Extra attention is needed label Oct 13, 2023
@zirain
Copy link
Member

zirain commented Oct 14, 2023

we should add valiation for other EG CRDs.

@arkodg arkodg removed the help wanted Extra attention is needed label Oct 26, 2023
@arkodg arkodg modified the milestones: 0.6.0-rc1, 0.6.0 Oct 26, 2023
@arkodg arkodg closed this as completed Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants