Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init CEL validation #2059

Merged
merged 10 commits into from
Oct 26, 2023
Merged

init CEL validation #2059

merged 10 commits into from
Oct 26, 2023

Conversation

zirain
Copy link
Member

@zirain zirain commented Oct 24, 2023

xref: #1964

@zirain zirain requested a review from a team as a code owner October 24, 2023 11:19
@zirain zirain mentioned this pull request Oct 24, 2023
Merged
@codecov
Copy link

codecov bot commented Oct 24, 2023 •
edited
Loading

Codecov Report

Merging #2059 (a2a5fdd) into main (bdb0191) will increase coverage by 0.03%.
Report is 9 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2059      +/-   ##
==========================================
+ Coverage   65.25%   65.29%   +0.03%     
==========================================
  Files          97       99       +2     
  Lines       14195    14640     +445     
==========================================
+ Hits         9263     9559     +296     
- Misses       4358     4497     +139     
- Partials      574      584      +10
Files Coverage Δ
api/v1alpha1/validation/envoyproxy_validate.go 76.28% <ø> (+1.11%) ⬆️

... and 16 files with indirect coverage changes

@zirain
simplify
a040050 
Signed-off-by: zirain <[email protected]>
@zirain
Copy link
Member Author

zirain commented Oct 24, 2023

/retest

arkodg
arkodg reviewed Oct 24, 2023
View reviewed changes
tools/make/kube.mk Outdated Show resolved Hide resolved
zirain added 2 commits October 25, 2023 06:15
@zirain
remove XValidation
8d2b017 
Signed-off-by: zirain <[email protected]>
@zirain
reuse kube-test
5cf018f 
Signed-off-by: zirain <[email protected]>
@zirain zirain requested a review from arkodg October 25, 2023 01:00
@zirain
revert nits
ee80bc8 
Signed-off-by: zirain <[email protected]>
@zirain zirain requested a review from arkodg October 26, 2023 01:30
arkodg
arkodg approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

Xunzhuo
Xunzhuo approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@Xunzhuo Xunzhuo merged commit edcb25b into envoyproxy:main Oct 26, 2023
18 checks passed
@zirain zirain deleted the cel-validation branch October 26, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xunzhuo Xunzhuo Xunzhuo approved these changes

@arkodg arkodg arkodg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zirain @arkodg @Xunzhuo