feat: add CEL validation for EnvoyProxy telemetry #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sh2 <[email protected]>
zirain
approved these changes
Oct 23, 2023
Codecov Report
@@ Coverage Diff @@
## main #2050 +/- ##
==========================================
- Coverage 64.33% 64.31% -0.02%
==========================================
Files 107 107
Lines 14665 14665
==========================================
- Hits 9434 9432 -2
- Misses 4664 4666 +2
Partials 567 567 |
Signed-off-by: sh2 <[email protected]>
|
@shawnh2 we've moved to CEL based validations, the newer tests live in https://github.com/envoyproxy/gateway/blob/main/test/cel-validation/envoyproxy_test.go, can we move the new test cases there instead and also make sure a CEL validation exists for it |
Signed-off-by: sh2 <[email protected]>
shawnh2
force-pushed
the
test-envoyproxy-validate
branch
from
fe930bf to
7162222
Compare
shawnh2
changed the title
arkodg
requested review from
a team,
qicz and
tanujd11
and removed request for
a team
zirain
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
add missing unit test cases
What this PR does / why we need it:
some unit test cases are missing according to https://app.codecov.io/gh/envoyproxy/gateway/blob/main/api%2Fv1alpha1%2Fvalidation%2Fenvoyproxy_validate.go
Which issue(s) this PR fixes:
Fixes #