Revert "Require peer certificate to be present when ca_cert_file is s… #668
Conversation
|
@lookuptable unfortunately we need to revert this. I forgot about a use case we have where we actually do need to accept SSL connections without a cert even when CA is specified. This is because we have an SSL endpoint where sometimes people have certs and sometimes we don't and we have whitelisting logic that handles this. Can you redo this change and make the behavior optional. I don't really care if you default to on, but we need to be able to turn the behavior off. This is for use with our client SSL auth filter: https://github.com/lyft/envoy/blob/master/source/common/filter/auth/client_ssl.cc |
|
@lyft/network-team |
|
@mattklein123 unless urgent, i'll do deploy on monday morning |
|
@RomanDzhabarov not urgent. I might be able to do one Sunday. But I think we can wait till Monday. |
|
Yup, sounds good either way |
…et (envoyproxy#648)" (envoyproxy#668) This reverts commit 1687644.
Description: previously Envoy Mobile was not guarded against a race that resulted in a double deletion of an Http::ConnectionManagerImpl::ActiveStream. This PR creates state that protects against that race. Risk Level: low, integration test reproe'd the stack trace, and then updated prod code fixed as expected. Testing: new integration test. Fixes #668 Signed-off-by: Jose Nino <[email protected]> Signed-off-by: JP Simard <[email protected]>
Description: previously Envoy Mobile was not guarded against a race that resulted in a double deletion of an Http::ConnectionManagerImpl::ActiveStream. This PR creates state that protects against that race. Risk Level: low, integration test reproe'd the stack trace, and then updated prod code fixed as expected. Testing: new integration test. Fixes #668 Signed-off-by: Jose Nino <[email protected]> Signed-off-by: JP Simard <[email protected]>
…et (#648)"
This reverts commit 1687644.