Skip to content
This repository has been archived by the owner on Feb 6, 2022. It is now read-only.

Differentiate "allow-all" and "allow-none" in ssl_context:verify_subject_alt_name #66

Closed
myidpt opened this issue Mar 23, 2017 · 4 comments
Assignees
Milestone

Comments

@myidpt
Copy link
Contributor

myidpt commented Mar 23, 2017

"allow-all": No secure naming is checked.
"all-none": Secure naming is checked against an empty list of service accounts. So it always fails.

We need to verify whether Envoy supports the two cases through config. Ideally, an undefined verify_subject_alt_name field should mean "allow-all" and a defined but empty verify_subject_alt_name field should mean "allow-none".

@myidpt myidpt self-assigned this Mar 23, 2017
@myidpt myidpt added the P2 label Mar 23, 2017
@lookuptable
Copy link
Member

This should be addressed by envoyproxy/envoy#615

@lookuptable lookuptable assigned lookuptable and unassigned myidpt Mar 23, 2017
@jasminejaksic-zz jasminejaksic-zz added this to the auth alpha milestone Mar 23, 2017
@lookuptable
Copy link
Member

envoyproxy/envoy#648 fixes this issue in Envoy upstream

@PiotrSikora
Copy link

Please note that envoyproxy/envoy#648 was reverted in Envoy (see: envoyproxy/envoy#615, envoyproxy/envoy#668).

@jasminejaksic-zz jasminejaksic-zz modified the milestones: auth beta, auth alpha Jun 6, 2017
@geeknoid geeknoid removed the P2 label Jun 22, 2017
@wattli
Copy link
Contributor

wattli commented Sep 27, 2017

@lookuptable , is this issue solved? I think currently we enforce client cert now.

@sakshigoel12 sakshigoel12 modified the milestones: Istio 0.2, Istio 0.3 Sep 28, 2017
@wattli wattli closed this as completed Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants