Require peer certificate to be present when ca_cert_file is set #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattklein123 PTAL |
There was a problem hiding this comment.
Looks good from code perspective, 1 small nit.
For docs, please add a small note to https://lyft.github.io/envoy/docs/configuration/listeners/ssl.html and https://lyft.github.io/envoy/docs/configuration/cluster_manager/cluster_ssl.html about how setting ca_cert_file requires that a certificate be presented or the connection will be failed.
source/common/ssl/context_impl.cc
Outdated
| @@ -229,6 +229,12 @@ bool ContextImpl::verifyPeer(SSL* ssl) const { | |||
|
|
|||
| if (!cert.get()) { | |||
| stats_.no_certificate_.inc(); | |||
|
|
|||
| if (ca_cert_) { | |||
| // In case that ca_cert_ exists, reject the connection when peer | |||
There was a problem hiding this comment.
nit: please flow comment out to 100 col
mattklein123
approved these changes
Mar 29, 2017
lookuptable
added a commit
to lookuptable/proxy
that referenced
this pull request
Mar 29, 2017
This is to pick up envoyproxy/envoy#648
Closed
vijayendrabvs
pushed a commit
to vijayendrabvs/envoy
that referenced
this pull request
Apr 4, 2017
…et (envoyproxy#648)" (envoyproxy#668) This reverts commit 1687644.
jplevyak
pushed a commit
to jplevyak/envoy
that referenced
this pull request
Sep 29, 2020
expose more rules
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Signed-off-by: Jose Nino [email protected] Description: #9618 broke the iOS build due to missing symbols. #9875 fixes. However, in order to expedite a clean master branch this PR moves the Envoy ref back to a stable place. Note that Android logging is reverted. Also note that CI for iOS was not testing for liveliness, which is how the breakage went through in the first place. This PR also fixes that. Risk Level: low Testing: CI Fixes #646 Signed-off-by: Jose Nino <[email protected]> Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Jose Nino [email protected] Description: #9618 broke the iOS build due to missing symbols. #9875 fixes. However, in order to expedite a clean master branch this PR moves the Envoy ref back to a stable place. Note that Android logging is reverted. Also note that CI for iOS was not testing for liveliness, which is how the breakage went through in the first place. This PR also fixes that. Risk Level: low Testing: CI Fixes #646 Signed-off-by: Jose Nino <[email protected]> Signed-off-by: JP Simard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #615