Remove runtime guard copy_response_code_to_downstream_stream_info
#33639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Bohanon <[email protected]>
jbohanon
force-pushed
the
jbohanon/remove-response-code-to-downstream-guard
branch
from
50281c5
to
5926fc0
Compare
|
/retest |
|
cc @yanavlasov (as approver of original PR) have a chance to look at this? I'll fix the changelog once I have the approvals; no need to thrash CI until then |
|
Author requested Yan's approval: |
|
LGTM. Please resolve merge conflict. /wait |
yanavlasov
approved these changes
Apr 24, 2024
|
Can someone with write access please merge? @adisuissa @yanavlasov |
cainelli
pushed a commit
to cainelli/envoy
that referenced
this pull request
Apr 25, 2024
…tream_info` (envoyproxy#33639) Signed-off-by: Jacob Bohanon <[email protected]>
alyssawilk
pushed a commit
to alyssawilk/envoy
that referenced
this pull request
Apr 29, 2024
…tream_info` (envoyproxy#33639) Signed-off-by: Jacob Bohanon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33615
Commit Message: Remove runtime guard
copy_response_code_to_downstream_stream_infoAdditional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]