Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove runtime guard copy_response_code_to_downstream_stream_info #33639

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Remove runtime guard copy_response_code_to_downstream_stream_info #33639

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5926fc0
remove runtime guard
jbohanon Apr 18, 2024
feb3842
Merge branch 'main' into jbohanon/remove-response-code-to-downstream-…
jbohanon Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelogs/current.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ bug_fixes:

removed_config_or_runtime:
# *Normally occurs at the end of the* :ref:`deprecation period <deprecated>`
- area: router
change: |
Removed ``envoy.reloadable_features.copy_response_code_to_downstream_stream_info`` runtime flag and legacy code paths.

new_features:

Expand Down
5 changes: 1 addition & 4 deletions source/common/router/router.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1655,10 +1655,7 @@ void Filter::onUpstreamHeaders(uint64_t response_code, Http::ResponseHeaderMapPt
callbacks_->streamInfo().setResponseCodeDetails(
StreamInfo::ResponseCodeDetails::get().ViaUpstream);

if (Runtime::runtimeFeatureEnabled(
"envoy.reloadable_features.copy_response_code_to_downstream_stream_info")) {
callbacks_->streamInfo().setResponseCode(response_code);
}
callbacks_->streamInfo().setResponseCode(response_code);

// TODO(zuercher): If access to response_headers_to_add (at any level) is ever needed outside
// Router::Filter we'll need to find a better location for this work. One possibility is to
Expand Down
1 change: 0 additions & 1 deletion source/common/runtime/runtime_features.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ RUNTIME_GUARD(envoy_reloadable_features_avoid_zombie_streams);
RUNTIME_GUARD(envoy_reloadable_features_check_mep_on_first_eject);
RUNTIME_GUARD(envoy_reloadable_features_conn_pool_delete_when_idle);
RUNTIME_GUARD(envoy_reloadable_features_convert_legacy_lb_config);
RUNTIME_GUARD(envoy_reloadable_features_copy_response_code_to_downstream_stream_info);
RUNTIME_GUARD(envoy_reloadable_features_defer_processing_backedup_streams);
RUNTIME_GUARD(envoy_reloadable_features_detect_and_raise_rst_tcp_connection);
RUNTIME_GUARD(envoy_reloadable_features_dfp_mixed_scheme);
Expand Down
Loading